Hi,

Quoting Ian Jackson (2016-12-20 18:47:45)
> Johannes Schauer writes ("Bug#848901: dgit: please allow deleting files with
> 3.0 (quilt)"):
> > dgit:  cannot represent change: deleted: foobar
> > dgit: HEAD has changes to .orig[s] which are not representable by `3.0 
> > (quilt)'
> > 
> > This is odd because when I just used git-format-patch and put the result
> > in debian/patches then dpkg-source is able to delete files just fine.
> > 
> > Maybe dgit could use this feature to support file deletion?
> 
> Hrm.  I think some versions of dpkg-source `accidentally' support
> deletion, because they simply feed the diff to whatever version of
> patch is in use.  We have accidentally produced incompatible source
> packages this way (ie unintentionally created source packages which
> were un-extractable on oldstable).

yup.

> But I don't think it is dgit's role to police this kind of thing.  I will fix
> the check to align with my understanding of dpkg-source.

Cool!

> Can you please tell me:
>  - instructions for fetching and identifying your git HEAD
>  - enough information to find any applicable .orig tarballs
>  - what exact dgit rune you typed
> ?
> 
> Then I can be sure to repro (and fix) exactly the right problem.

After cloning a dgit repo I just did "git rm foobar" and then "git commit". The
error occurred when I ran "dgit build-source". I don't think this is specific
to the exact commands I ran but I was able to reproduce the issue by doing:

 $ dgit clone botch
 $ git rm tests/selfcontained/out/cyclic_src:apache2_950.xml
 $ git commit -m "delete apache"
 $ dgit build-source

Thanks!

cheers, josch

Attachment: signature.asc
Description: signature

Reply via email to