Control: forwarded -1 https://github.com/SciRuby/rb-gsl/issues/41
Hi Dirk, 2016-12-22 6:04 GMT+01:00 Dirk Eddelbuettel <e...@debian.org>: > > On 22 December 2016 at 03:18, Bálint Réczey wrote: > | 2016-12-22 2:53 GMT+01:00 Dirk Eddelbuettel <e...@debian.org>: > | > > | > On 22 December 2016 at 01:57, Bálint Réczey wrote: > | > | Hi Dirk, > | > | > | > | 2016-12-19 23:58 GMT+01:00 Dirk Eddelbuettel <e...@debian.org>: > | > | > > | > | > Hi Balint, > | > | > > | > | > On 19 December 2016 at 13:57, Bálint Réczey wrote: > | > | > | Hi Dirk, > | > | > | > | > | > | 2016-12-19 0:30 GMT+01:00 Dirk Eddelbuettel <e...@debian.org>: > | > | > | > > | > | > | > On 10 November 2016 at 13:22, Balint Reczey wrote: > | > | > | > | Control: reassign -1 gsl 2.2.1+dfsg-1 > | > | > | > | Control: affects -1 ruby-gsl > | > | > | > | > | > | > | > | > | > | > | > | Hi Dirk, > | > | > | > | > | > | > | > | It seems ruby-gsl is missing some deprecated functions. > | > | > | > | Please re-enable debian/patches/dont-disable-deprecated to let > ruby-gsl > | > | > | > | build again. > | > | > | > > | > | > | > Well I could -- but according to > https://github.com/SciRuby/rb-gsl a current > | > | > | > ruby-gsl exists. > | > | > | > > | > | > | > Why are we stuck with the 1.* series? Should we not port forward? > | > | > | > | > | > | I tried updating to 2.1.0 but it still uses deprecated functions, > | > | > | hence the reassignment. > | > | > > | > | > Well I'd rather not. I think upstream would rather see a plainer > versions. > | > | > > | > | > Can you detail what is missing? > | > | > > | > | > Also see > https://github.com/SciRuby/rb-gsl/blob/master/ChangeLog#L3-L7 which says > | > | > > | > | > == Fri March 4 2016 > | > | > * Added compatibility for NMatrix interconversion with GSL::Vector > and GSL::Matrix > | > | > * Added NMatrix compatibility to various to make them compatible with > NMatrix data types. > | > | > * Gem is now compatible with GSL 2.1. > | > | > * Version bump to 2.1.0 > | > | > > | > | > Sounds to me it should work with our version. > | > | > | > | Ruby-gsl is compatible with GSL 2.1 when deprecated symbols are not > | > | disabled in GSL. > | > > | > I think we are talking past each other / you are avoiding my questions. > | > | It was not my intention. I'm trying to be even more clear. > | > | > > | > It seems that you are at rb-gsl 1.6.* when 2.1.* is out. Why? Can you > not upgrade? > | > | Because rb-gsl 2.1 does not compile with GSL when GSL disables the > | deprecated functions. > | Yes, I can not upgrade without this bug being fixed. > | > | You can check the prepared rb-gsl in the repo I linked to. > > Ok. I can see a little more clearly now. > > I think we're closing to deadlock situation. I think we all would like to > move to 2.1 everywhere. You say you can, so you want to do more deprecated > functions ... but that just worsens the situation. I'm not sure what you mean by "do more deprecated functions". I have to to keep rb-gsl's external API and my proposal was providing the deprecated functions in gls thus rb-gsl can wrap them and keep providing the Ruby interface. > > It has been a while since I looked at this, but maybe we can do __without__ > the deprecated functions, and then you, me, ... can all be at 2.1. > > Would that not be better? If that means removing functions from the API provided by rb-gsl then this is a no-go for me because that would make Debian's rb-gsl 2.1 having a different API form rb-gsl 2.1 available elsewhere and there is no practical way of distinguishing those in Ruby - unlike using different .so names in libraries with C interface. If your proposal is keeping deprecated functions disabled in GLS and reimplementing them in rb-gsl and wrapping those functions int rb-gsl-s unchanged API then that would work in theory and this is what I started doing in the attached patch. However this approach needs more work which I can't promise to do, and more importantly does not seem to be better option for GSL/rb-gsl users, just for GSL upstream. As a user of an API I always prefer having deprecated functions available, except when I work on migrating away for the deprecated functions and disabling the completely help discovering the parts to fix. IMO in Debian stable we give the best service four our users by _not_ disabling deprecated functions. In unstable/testing we may disable deprecated functions at the beginning/middle of the release cycle when we are far from the freeze but removing functions from APIs close to the freeze needs to be done with care as not all upstreams can adapt fast. Cheers, Balint > > Dirk > > | Cheers, > | Balint > | > | > > | > I am really not that interested in supporting one random client package > that > | > refuses to upgrade, when all other operate just fine. > | > > | > But maybe I am missing something here. Can you clarify? > | > > | > Dirk > | > > | > | I have started removing references to them with > | > | gsl_sf_legendre_array_size(), but > | > | then the next one build is failing with is > gsl_sf_legendre_sphPlm_array() : > | > | > | > | ... > | > | *** running test/gsl_test.rb *** > | > | /usr/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:55:in > | > | `require': > /<<BUILDDIR>>/ruby-gsl-2.1.0+dfsg1/debian/ruby-gsl/usr/lib/i386-linux-gnu/ruby/vendor_ruby/2.3.0/gsl_native.so: > | > | undefined symbol: gsl_sf_legendre_sphPlm_array - > | > | > /<<BUILDDIR>>/ruby-gsl-2.1.0+dfsg1/debian/ruby-gsl/usr/lib/i386-linux-gnu/ruby/vendor_ruby/2.3.0/gsl_native.so > | > | (LoadError) > | > | from /usr/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:55:in > `require' > | > | from > /<<BUILDDIR>>/ruby-gsl-2.1.0+dfsg1/debian/ruby-gsl/usr/lib/ruby/vendor_ruby/gsl.rb:11:in > | > | ... > | > | > | > | I used the attached patch on top of > | > | https://anonscm.debian.org/cgit/pkg-ruby-extras/ruby-gsl.git master . > | > | > | > | IMO since ruby-gsl 2.1 provides the symbols which are deprecated in > | > | GSL unconditionally I can't remove them > | > | from ruby-gsl's API thus ruby-gsl needs deprecated GSL functions to be > | > | provided by GSL. > | > | > | > | I understand that upstreams would like to see code migrating from the > | > | deprecated functionality fast, but immediate removal is not the best > | > | for users IMO. > | > | > | > | Cheers, > | > | Balint > | > | > | > | > > | > | > Dirk > | > | > > | > | > | > | > | > | Cheers, > | > | > | Balint > | > | > | > | > | > | > > | > | > | > Dirk > | > | > | > > | > | > | > | Cheers, > | > | > | > | Balint > | > | > | > | > | > | > | > | On Fri, 21 Oct 2016 15:37:05 +0200 Lucas Nussbaum > <lu...@debian.org> wrote: > | > | > | > | > Source: ruby-gsl > | > | > | > | > Version: 1.16.0.6+dfsg1-2 > | > | > | > | > Severity: serious > | > | > | > | > Tags: stretch sid > | > | > | > | > User: debian...@lists.debian.org > | > | > | > | > Usertags: qa-ftbfs-20161021 qa-ftbfs > | > | > | > | > Justification: FTBFS on amd64 > | > | > | > | > > | > | > | > | > Hi, > | > | > | > | > > | > | > | > | > During a rebuild of all packages in sid, your package failed > to build on > | > | > | > | > amd64. > | > | > | > | > > | > | > | > | > Relevant part (hopefully): > | > | > | > | > > > /usr/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:55:in `require': > /<<BUILDDIR>>/ruby-gsl-1.16.0.6+dfsg1/debian/ruby-gsl/usr/lib/x86_64-linux-gnu/ruby/vendor_ruby/2.3.0/gsl_native.so: > undefined symbol: gsl_sf_legendre_array_size - > /<<BUILDDIR>>/ruby-gsl-1.16.0.6+dfsg1/debian/ruby-gsl/usr/lib/x86_64-linux-gnu/ruby/vendor_ruby/2.3.0/gsl_native.so > (LoadError) > | > | > | > | > > from > /usr/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:55:in `require' > | > | > | > | > > from > /<<BUILDDIR>>/ruby-gsl-1.16.0.6+dfsg1/debian/ruby-gsl/usr/lib/ruby/vendor_ruby/gsl.rb:6:in > `<top (required)>' > | > | > | > | > > from > /usr/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:55:in `require' > | > | > | > | > > from > /usr/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:55:in `require' > | > | > | > | > > from test_helper.rb:2:in `<main>' > | > | > | > | > > ERROR: Test "ruby2.3" failed: > | > | > | > | > > | > | > | > > | > | > | > -- > | > | > | > http://dirk.eddelbuettel.com | @eddelbuettel | e...@debian.org > | > | > > | > | > -- > | > | > http://dirk.eddelbuettel.com | @eddelbuettel | e...@debian.org > | > | x[DELETED ATTACHMENT > 0001-WIP-Fix-FTBFS-due-to-missing-gsl_sf_legendre_array_s.patch, text/x-diff] > | > > | > -- > | > http://dirk.eddelbuettel.com | @eddelbuettel | e...@debian.org > > -- > http://dirk.eddelbuettel.com | @eddelbuettel | e...@debian.org
