Hi,
as announced on IRC, I'm just doing a review, since I'm not a DD
and can't sponsor:
- packaging in a VCS would be nice to have (plus the appropriate
Vcs-Browser / Vcs-... headers in d/control)
- debian/copyright:
* Tobias Klauser wasn't just active in 2016, the earliest
copyright notice of his I could find in the package is
from 2014; so s/2016/2014-2016/ there
* missing mention of Copyright (C) 2012 Christoph Jaeger
for pkt.h
* missing mention of Copyright (C) 2009-2012 Daniel
Borkmann for util.[ch]
- debian/compat: why only 9? compat 10 is considered stable now
and unless you have a good reason I would recommend that any new
package should use compat 10. (please read the debhelper manual
though for information on what changed between 9 and 10)
- init.d: this file name works with dh_installinit, but is not
documented, so I'd recommend using llmnrd.init as the file name
- init.d: any particular reason you don't use init-d-script? (See
current /etc/init.d/skeleton for how this works; it will
automatically source /etc/default/$scriptname and interpret the
DAEMON_ARGS variable, so your init script could probably be just
a couple of lines that set the name of the executable)
- any reason you don't install the systemd service provided by
upstream in addition to the init script?
- debian/rules: nice and clean, I like it
- upstream's build system does git id to get the git revision of
the current source - but that will clash if you have the packaging
in git (which can happen implicitly when someone checks out the
package source via e.g. dgit)
Minor cosmetic thing, but makes the package non-reproducible
depending on whether you build from unpacked .dsc or from a git
environment
- lintian warnings:
W: llmnrd: binary-without-manpage usr/bin/llmnr-query
W: llmnrd: binary-without-manpage usr/sbin/llmnrd
- you should probably add a line "export Q =" to debian/rules to
disable silent builds. While these look nicer, automated build
log scanners such as blhc aren't able to catch problems.
- Building in sbuild appears to work fine.
- Package appears to work fine (though I don't have any llmnr
device running at the moment, so I could only test name
resolution of my own system)
Regards,
Christian
