Control: severity -1 important
Control: tag -1 + patch
Hi,
Ingo Saitz wrote:
> On Tue, Dec 13, 2016 at 11:47:32AM -0500, Daniel Echeverry wrote:
> > thanks for your report, Unfortunately I can't reproduce this issue,
> > Could you confirm from which glances version are you trying to update?
>
> From /var/lib/dpkg.log:
> 2016-12-13 12:27:44 upgrade glances:all 2.6.2-2 2.7.1.1-1
Same here:
2016-12-10 22:15:51 upgrade glances:all 2.6.2-2 2.7.1.1-1
> So I was just upgrading from the previous glances version in unstable,
> 2.6.2-2. But I think the upgrade might be broken longer, Since this is
> the first upgrade of this package on my system:
>
> 2016-11-12 14:49:01 install glances:all <none> 2.6.2-2
I have glances installed since 2.5.1-1 (installed on 2016-05-04), but
/etc/default/glances which disables the daemon is even older.
> Have you tried upgrading (using sysvinit as init) without running
> glances server? The problem is, i believe, in the initscript, which gets
> called as /etc/init.d/glances reload on upgrade, but exits with an error
> code if the glances server is configured not to run. I have attached a
> patch for the initscript, which fixes the return code from
> /etc/init.d/glances reload by ignoring the failure to stop the glances
> server, when none should be running.
This observation fits with my observation. Also using sysvinit here.
IMHO this is of severity serious since it causes an dist-upgrade
failure ever since this started, but since it only happens with a
non-default init system, I'm only raising this to severity important.
Feel free to raise the severity further.
Random excerpt from my dpkg.log:
2016-12-14 17:41:06 status half-configured glances:all 2.7.1.1-1
2016-12-14 17:41:35 configure glances:all 2.7.1.1-1 <none>
2016-12-14 17:41:35 status half-configured glances:all 2.7.1.1-1
2016-12-15 13:39:47 configure glances:all 2.7.1.1-1 <none>
2016-12-15 13:39:47 status half-configured glances:all 2.7.1.1-1
2016-12-15 13:40:19 configure glances:all 2.7.1.1-1 <none>
2016-12-15 13:40:19 status half-configured glances:all 2.7.1.1-1
2016-12-16 02:18:09 configure glances:all 2.7.1.1-1 <none>
2016-12-16 02:18:09 status half-configured glances:all 2.7.1.1-1
2016-12-16 02:19:29 configure glances:all 2.7.1.1-1 <none>
2016-12-16 02:19:29 status half-configured glances:all 2.7.1.1-1
2016-12-16 11:55:39 configure glances:all 2.7.1.1-1 <none>
2016-12-16 11:55:39 status half-configured glances:all 2.7.1.1-1
2016-12-16 11:56:03 configure glances:all 2.7.1.1-1 <none>
2016-12-16 11:56:03 status half-configured glances:all 2.7.1.1-1
2016-12-17 03:03:47 configure glances:all 2.7.1.1-1 <none>
2016-12-17 03:03:47 status half-configured glances:all 2.7.1.1-1
2016-12-17 03:04:19 configure glances:all 2.7.1.1-1 <none>
2016-12-17 03:04:19 status half-configured glances:all 2.7.1.1-1
2016-12-17 17:16:24 configure glances:all 2.7.1.1-1 <none>
2016-12-17 17:16:24 status half-configured glances:all 2.7.1.1-1
2016-12-17 17:19:24 configure glances:all 2.7.1.1-1 <none>
2016-12-17 17:19:24 status half-configured glances:all 2.7.1.1-1
2016-12-17 17:20:15 configure glances:all 2.7.1.1-1 <none>
2016-12-17 17:20:15 status half-configured glances:all 2.7.1.1-1
2016-12-19 17:15:48 configure glances:all 2.7.1.1-1 <none>
2016-12-19 17:15:48 status half-configured glances:all 2.7.1.1-1
That's the annoying part of this bug.
> --- a/etc/init.d/glances 2016-12-14 11:14:04.000000000 +0100
> +++ b/etc/init.d/glances 2016-12-14 11:13:43.000000000 +0100
> @@ -118,7 +118,12 @@ case "$1" in
> ;;
> *)
> # Failed to stop
> - log_end_msg 1
> + if [ "$RUN" != "true" ]; then
> + log_action_msg "disabled by /etc/default/$NAME"
> + log_end_msg 0
> + else
> + log_end_msg 1
> + fi
> ;;
> esac
> ;;
I'll test that patch later.
Regards, Axel
--
,''`. | Axel Beckert <[email protected]>, http://people.debian.org/~abe/
: :' : | Debian Developer, ftp.ch.debian.org Admin
`. `' | 4096R: 2517 B724 C5F6 CA99 5329 6E61 2FF9 CD59 6126 16B5
`- | 1024D: F067 EA27 26B9 C3FC 1486 202E C09E 1D89 9593 0EDE
