Hello again I shall go through it with a fine toothcomb over the next few days. Yes, this may be a better method. At the moment, I make changes as I can, which can result in loosing track of what I've done. I shall experiment with using git like this and see how I go on. With the packages that I've been putting up to mentors I've been constructing a mental checklist of what I'm learning, need to start putting it down in writing and following it rigidly.
I shall let you know when I've reuploaded Many Thanks David On 28 December 2016 at 22:47, Sean Whitton <spwhit...@spwhitton.name> wrote: > control: owner -1 ! > > Hello David, > > On Wed, Dec 28, 2016 at 09:12:49PM +0000, David Davies-Jones wrote: > > I've tried addressing the issues you've raised and re-uploaded to > mentors. If > > there are any more problems please let me know > > Thanks for your updated package. I'm sorry not to have raised this in > my previous message, but there are other changes you've made that are > not documented in the changelog. For example, you dropped some > build-dependencies, and you renamed a quilt patch. Please check the > difference between 0.6.1-3 and 0.7.1-1 carefully. > > Tip: it's easier if you work in git, rather than just handling source > packages. This is what I just did to review your work: > > % dget -d https://mentors.debian.net/debian/pool/main/d/darksnow/ > darksnow_0.7.1-1.dsc > % dgit clone darksnow > % dgit import-dsc ../darksnow_0.7.1-1.dsc david > % git checkout david > % git diff dgit/dgit/sid..HEAD > > By the way, it would be good to forward your darksnow.desktop upstream > (that won't be reflected in your QA upload, of course). > > -- > Sean Whitton >
