Hi, On 08/30/2016 10:17 AM, Martin Pitt wrote: > Please drop it as this is unnecessary extra parsing work at boot. I > attach an untested (only build-tested) initial patch. The main thing > I'm not sure about is whether this actually needs to clear > /etc/network/interfaces when NetworkManager is installed -- would > anything write "real" interfaces to /e/n/i in this case?
it needs to, yes. Otherwise you end up with the interface being unmanaged from n-m, despite the n-m snippet having been written. I suppose what we could do is just empty it out. At least trying that out was successful for me. I also tested the non n-m case and that was fine. > In a more general vein, ifupdown creates an appropriate /e/n/i on > package installation already. It would be nicer if netcfg would not > completly overwrite this and instead just add files to > /etc/network/interfaces.d/ Yeah, I suppose we could do that. Is there already a naming convention here? Would /etc/network/interfaces.d/${interface}.conf work? (Note that for n-m we use a generic untranslated "Wired connection 1" with no adapter matching specified in the snippet.) Similarly I guess we could pre-configure systemd-networkd in some way, but right now there's no package to check for. (Which is how we determine if network-manager configuration needs to be written out.) Kind regards and thanks Philipp Kern
signature.asc
Description: OpenPGP digital signature