Thank you for your review! On Sun, Jan 08, 2017 at 02:23:42PM -0400, David Bremner wrote: > I think you mean -4 and below
Yes.
> > +# also installed. We manually upgrade the emacsen-common remove
> > +# script so that it won't exit non-zero, which blocks the upgrade
>
> > +if [ "$1" = "failed-upgrade" ] && dpkg --compare-versions "$2" lt
> > 0.8.12-5; then
> > +
> > broken_remove_script="/usr/lib/emacsen-common/packages/remove/elpa-company"
> > + sed --quiet -i "$broken_remove_script" \
> > + -e 's/find ${elc_dir} -type l -delete/[ -d ${elc_dir} ] && find
> > ${elc_dir} -type l -delete/'
>
> this is OK, but it might be simpler to add the 'exit 0' that dh-elpa 1.6
> added to the xemacs case.
Okay.
> > + sed --quiet -i "$broken_remove_script" \ + -e
> > 's/emacs23)/emacs2[0123]*)/'
>
> this seems unrelated to the problem in the comments. Did you mean to say
> something like "xemacs21 or gnu emacs version 20-22"
It's unrelated, but I thought it would be best to update the
emacsen-common remove script completely to avoid any other upgrade
issues that might arise. Would you prefer to keep the fix more minimal?
--
Sean Whitton
signature.asc
Description: PGP signature
