On Tue, 10 Jan 2017 23:49:43 +0100 Christian Hofstaedtler wrote:

> Hi,

Hello Christian!   :-)

First off, many thanks for stepping in.

I really appreciate that you're proposing a longer term solution than
what I was thinking about (I was planning to propose a little patch for
the apcupsd.init file, but writing a dedicated apcupsd.service file is
clearly cleaner and better).

> 
> * Daniel Pocock <dan...@pocock.pro> [170106 11:06]:
> > > Is anyone able to reproduce the issue on current Debian testing?
> > > 
> > 
> > How long does it take for your apcupsd daemon to shutdown?
> > 
> > My UPS uses SNMP signalling, I wonder if that makes the daemon shut
> > down more slowly.
> 
> Likely.
> 
> I can't test this (my UPS is broken and it'd be a serial one
> anyway), but here are some test packages with a systemd service
> file:
> 
> https://people.debian.org/~zeha/apcupsd/
> 
> Please report back if those work for you and if the restart issue
> is fixed.

I haven't had a chance to actually test the package, but, as far as
tests are concerned, let's primarily wait for Daniel's feedback (that
will hopefully arrive real soon now!).

However, I glanced over the diff between
apcupsd_3.14.14-0.2.debian.tar.xz and the proposed
apcupsd_3.14.14-0.3.debian.tar.xz: the only thing that looks suspicious
is that the apcupsd.service file seems to lack any check for the
ISCONFIGURED variable in /etc/default/apcupsd (unlike apcupsd.init,
which aborts whenever that variable is not set to "yes").

Is this intentional?
I think that the check should be implemented somehow...

Please let me know.
Thanks a lot for your time!


-- 
 http://www.inventati.org/frx/
 There's not a second to spare! To the laboratory!
..................................................... Francesco Poli .
 GnuPG key fpr == CA01 1147 9CD2 EFDF FB82  3925 3E1C 27E1 1F69 BFFE

Attachment: pgp3PiWHryNrL.pgp
Description: PGP signature

Reply via email to