On Sat, Jan 14, 2017 at 11:30:54PM +0000, Ian Jackson wrote: > Package: dpkg-source > Version: 1.18.15 > > To reproduce: > git clone git://git.chiark.greenend.org.uk/~ianmdlvl/dgit.git > cd dgit > git checkout for-dpkg-source.2017-01-14 > DGIT_DRS_DEBUG=2 DGIT_TEST_DEBUG=-D tests/using-intree \ > tests/tests/gitattributes 2>&1 </dev/null | tee tests/tmp/u.log > > You may need to install the test dependencies: > dgit, dgit-infrastructure, devscripts, debhelper (>=8), fakeroot, > build-essential > > Observed behaviour: > dpkg-source goes into an infinite loop printing > Enter the desired patch name: > > Expected behaviour: > It should stop with some kind of error message, or perhaps > carry on with a default patch name
Easier reproduction: run dpkg-source --commit in any 2.0 or 3.0 (quilt) package tree that has been modified, then send an EOF at the prompt. This is a pretty simple bug, too: Dpkg/Source/Package/V2.pm:725 (sub do_commit) loops until it gets a valid string from stdin, but treats an undefined value as invalid, rather than aborting or using a default patch name. Regards, James
