Chiming in here because I can send email.

* Andreas Henriksson <andr...@fatal.se> [170122 15:31]:
> [andreas was looking at the unsupported features in su from
> util-linux]:
> [..]
>
> > DEFAULT_HOME
> 
> util-linux has the opposite default (only warn), and doesn't support
> manual configuring this setting.
> http://sources.debian.net/src/util-linux/2.29.1-1/login-utils/su-common.c/#L979
> 
> Might be useful to implement support for this setting in util-linux.
> Question remains about default, maybe implement a configure time setting
> for the default?
> 
> How much do we really care about this setting though?
> 
> I personally don't think this is a blocker (for su - for login it would
> be important to support it), would rather consider it a wishlist feature
> request than anyone is free to submit a patch to upstream for if they
> want to see it supported.
> 
> 
> => consider as potential wishlist-severity feature request if anyone is
>    interested?!

The /etc/login.defs file as shipped in login today has this set to
"yes". Having login and su behave differently does not appear to be an
option today, so I don't think "no" for this setting is actually important?


> > SULOG_FILE
> 
> It seems shadow had the intention for *optional* support of syslog (but
> it's actually always enabled at compile-time and configurable at
> runtime), and non-optional support for built-in logging system. This is
> likely something we want the opposite way around in a modern system, so
> I'd advocate for deprecating this option if we move to util-linux su.
> 
> 
> => consider deprecated?! (Possibly implement a warning on upgrades on
>    systems which has it set?)

+1

> > SU_NAME
> 
> This seems like a pretty superficial feature to me.
> 
> (Note: messing with argv0 also seems to cause problems when busybox
> is being used as /bin/sh as experienced by OpenEmbedded.)
> 
> => consider deprecated?!

+1

> > SYSLOG_SU_ENAB
> 
> In util-linux syslog logging is mandatory. I don't see a reason to be
> able to switch it off.
> 
> 
> => consider deprecated?!

+1

> ----
> 
> Also note the following su related patches carried in Debian shadow package:
> http://sources.debian.net/src/shadow/1:4.4-2/debian/patches/523_su_arguments_are_concatenated/
> http://sources.debian.net/src/shadow/1:4.4-2/debian/patches/523_su_arguments_are_no_more_concatenated_by_default/
> Both seems obsolete (the second one even says to be dropped after etch
> which was released 2007).
> (Also pbuilder seems to have switched from su to start-stop-daemon.)

Dropping the second one sure sounds safe, but the first one looks
like it changes commonly used behaviour? How does su from util-linux handle
that?


Cheers,
-- 
christian hofstaedtler <z...@debian.org>

Reply via email to