Hi Niels,

that's the problem with debdiff as the php extensions can't handle the
renamed directory (that contains the upstream version number).

git diff is much better at that as it can handle the file renames - look
at the "similarity index" lines in the diff I have attached.

Cheers,
-- 
Ondřej Surý <ond...@sury.org>
Knot DNS (https://www.knot-dns.cz/) – a high-performance DNS server
Knot Resolver (https://www.knot-resolver.cz/) – secure, privacy-aware,
fast DNS(SEC) resolver

On Thu, Feb 2, 2017, at 18:59, Niels Thykier wrote:
> Control: tags -1 moreinfo
> 
> Ondřej Surý:
> > Package: release.debian.org
> > Severity: normal
> > User: release.debian....@packages.debian.org
> > Usertags: unblock
> > 
> > Please unblock package php-redis
> > 
> > Please unblock php-redis 3.1.1.  There are no upstream changes other
> > than version change from 3.1.1~rc2 and it would create tons of
> > questions why Debian has 3.1.1~rc2 even though the codebase is same.
> > 
> > (The other option would be to allow php-redis to migrate faster.)
> > 
> > $ git diff upstream/3.1.1_rc2..upstream/3.1.1 | diffstat
> >  package.xml             |   34 +++++++++++++++++-----------------
> >  redis-3.1.1/php_redis.h |    2 +-
> >  2 files changed, 18 insertions(+), 18 deletions(-)
> > 
> > unblock php-redis/3.1.1
> > 
> > [...]
> > 
> 
> Hi,
> 
> The actually I see between 3.1.1~rc2-1 to 3.1.1-1 is huge (see below).
> Did something go wrong in that upload?
> 
> """
> respight.d.o$ d php-redis
> php-redis (3.1.1~rc2-1 to 3.1.1-1)
>     Maintainer: Debian PHP PECL Maintainers
>     Too young, only 0 of 10 days old
>     Piuparts tested OK - [...]
>     Not considered
> 
> Filter applied (not reflected in the diffstat):
>   filterdiff -x **/*.po -x **/*.pot
> 
>  debian/changelog                          |    8
>  package.xml                               |   34
>  redis-3.1.1/COPYING                       |   68
>  redis-3.1.1/CREDITS                       |    5
>  redis-3.1.1/README.markdown               | 3375 ++++++++++++++++++++
>  redis-3.1.1/arrays.markdown               |  155
>  redis-3.1.1/cluster.markdown              |  178 +
>  redis-3.1.1/cluster_library.c             | 2487 ++++++++++++++
>  redis-3.1.1/cluster_library.h             |  467 ++
>  redis-3.1.1/common.h                      |  686 ++++
>  redis-3.1.1/config.m4                     |  103
>  redis-3.1.1/config.w32                    |   27
>  redis-3.1.1/crc16.h                       |   87
>  redis-3.1.1/library.c                     | 2371 ++++++++++++++
>  redis-3.1.1/library.h                     |  111
>  redis-3.1.1/php_redis.h                   |  303 +
>  redis-3.1.1/redis.c                       | 3856 [...]
>  redis-3.1.1/redis_array.c                 | 1356 ++++++++
>  redis-3.1.1/redis_array.h                 |   62
>  redis-3.1.1/redis_array_impl.c            | 1223 +++++++
>  redis-3.1.1/redis_array_impl.h            |   34
>  redis-3.1.1/redis_cluster.c               | 3051 ++++++++++++++++++
>  redis-3.1.1/redis_cluster.h               |  300 +
>  redis-3.1.1/redis_commands.c              | 3248 +++++++++++++++++++
>  redis-3.1.1/redis_commands.h              |  269 +
>  redis-3.1.1/redis_session.c               |  790 ++++
>  redis-3.1.1/redis_session.h               |   22
>  redis-3.1.1/tests/RedisArrayTest.php      |  554 +++
>  redis-3.1.1/tests/RedisClusterTest.php    |  524 +++
>  redis-3.1.1/tests/RedisTest.php           | 4988 [...]
>  redis-3.1.1/tests/TestRedis.php           |   60
>  redis-3.1.1/tests/TestSuite.php           |  180 +
>  redis-3.1.1/tests/make-cluster.sh         |  142
>  redis-3.1.1/tests/mkring.sh               |   55
>  redis-3.1.1RC2/COPYING                    |   68
>  redis-3.1.1RC2/CREDITS                    |    5
>  redis-3.1.1RC2/README.markdown            | 3375 --------------------
>  redis-3.1.1RC2/arrays.markdown            |  155
>  redis-3.1.1RC2/cluster.markdown           |  178 -
>  redis-3.1.1RC2/cluster_library.c          | 2487 --------------
>  redis-3.1.1RC2/cluster_library.h          |  467 --
>  redis-3.1.1RC2/common.h                   |  686 ----
>  redis-3.1.1RC2/config.m4                  |  103
>  redis-3.1.1RC2/config.w32                 |   27
> [...]
> """
> 
> 
> 

Reply via email to