On Thu, Feb 02, 2017 at 12:06:30AM +0100, Jens Reyer wrote:
> I first build the binary packages to test them. Only once everything is
> fine I build the source package for uploading, using gbp's magic to git
> tag the release.  This workflow saves me from accidentally
> uploading/pushing something wrong, and at the same time I'm able to
> change minor things and release them, without having to rebuild the
> binary packages (which takes some time for Wine).
> 
> Further it's just laziness: use the same command for all kinds of
> builds, just change one or two options.
> 
> So this is a small plea to reconsider this decision for source-only.
> But of course, I can definitely set up something working again with your
> explanations and the new --source-only-changes, thanks!

Yeah, please use --source-only-changes over `--debbuildopts -S` which
makes no sense at all.

> > For binary-indep-only, I assume you are using -A, which git-pbuilder sees 
> > as a
> > dpkg-buildpackage option and passes on to cowbuilder via --debbuildopts.
> > However, cowbuilder/pbuilder do not look at debbuildopts to determine what 
> > kind
> > of build is being done; they have their own flags. Please use
> > --binary-arch/--binary-indep as per the pbuilder man page (you may need to 
> > use
> > --git-pbuilder-options=--binary-indep to get it passed through properly).
> 
> Yes, I used -A. Funnily, the similar command with -B worked (building
> only the arch binaries, but not the indep ones).

The reason of this failure is that pbuilder looks for
$pkg_$ver_$arch.changes for full builds and binary builds, and
$pkg_$ver_all.changes for indep builds (falling back to the
$arch.changes as old versions of dpkg named that way).  pbuilder knows
the build type if you pass --binary-(arch|indep), so it can look for the
right name, but if you bypass the option and pass -A/-B directly to dpkg
it won't know it.
In the past it used to work because pbuilder just copied every
*.changes file it would find in the build directory, now it became a bit
more picky.
Fixing this would be as easy as always looking for a _all.changes,
regardless of the build type, but I do not think it would be a clever
move: it's really something that is wrong in the original invocation.

Besides, using -A/-B always install all of the Build-Depends* and you
won't benefith of the Build-Depends-Arch/Build-Depends-Indep separation.

> Wow, I admit I didn't have a look at the pbuilder manpage for a long
> time, but indeed this is very well described there.  With this new
> knowledge I'm totally fine with this change.

Are you?
As said, there are no way -S is going to be supported, that's just plain
stupid IMHO, but I can be convinced in supporing -A in --debbuildopts by
always looking at _all.changes.

-- 
regards,
                        Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540      .''`.
more about me:  https://mapreri.org                             : :'  :
Launchpad user: https://launchpad.net/~mapreri                  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-

Attachment: signature.asc
Description: PGP signature

Reply via email to