Package: keepalived
Version: 1:1.3.2-1
Severity: normal

Hi,
debugging an issue recently I found that upstream now has a service file.
While some differences would make a full adoption at least "more work"
(like different config paths).
There are still a few things we could easily take up into the Debian file.

One change that might help is to add "PIDFile=/var/run/keepalived.pid".
I've happened to debug cases [1] where a fast restart of keepalived tricks
systemds PID guessing and thereby can end up with stale configuration and
processes. The PIDFile statement fixes that - and while newer systemd
versions seem to avoid the issue as well I think it might still be safe as
it is recommended for services of type forking.
It would be kind if you'd consider taking the PIDFile statement into the
Debian service file of keepalived.

There is also "After=syslog.target" as a difference but I'm not so sure how
much sense that makes in the Debian context.
[1]: https://bugs.launchpad.net/ubuntu/+source/keepalived/+bug/1644530

-- 
Christian Ehrhardt
Software Engineer, Ubuntu Server
Canonical Ltd

Reply via email to