Control: tags -1 - patch + moreinfo

On Tue, Mar 14, 2017 at 01:33:09PM +0100, Bastien ROUCARIES wrote:
> package: needrestart
> version: 2.11-2
> severity: important

Using severity important for anything DPKG_ROOT related sounds dubious
to me, because the feature is not finalized in dpkg, but a technology
preview.

> tag: patch

Please add the patch tag again once attaching the patch.

> Testing dpkg testsuite without beeing root needrestart crash.

Maybe you can give more details here as to what crashes and how it
fails?

> I believe need restart need to take in account $DPKG_ROOT

You mentioned on irc that the file you want to touch is
/etc/dpkg/dpkg.cfg.d/needrestart. That's not a maintainer script.
DPKG_ROOT is only defined during maintainer script execution. Thus
DPKG_ROOT will be undefined here.

> at least it should not execute if dpkg-root is set (so patch)

Why should execution of needrestart depend on the way maintainer scripts
are executed? That doesn't make any sense to me. Shouldn't the real
condition be something like skipping needrestart when it is not
installed in the system /?

Helmut

Reply via email to