Control: retitle -1 cylc can FTBFS when build directory contains underscore
Control: severity -1 serious

On Thu, Mar 09, 2017 at 10:12:18PM +0000, Chris Lamb wrote:
> Source: cylc
> Version: 6.11.2-4
> Severity: wishlist
> Tags: patch
> User: reproducible-bui...@lists.alioth.debian.org
> Usertags: buildpath
> X-Debbugs-Cc: reproducible-b...@lists.alioth.debian.org
> 
> Hi,
> 
> Whilst working on the Reproducible Builds effort [0], we noticed
> that cylc could not be built reproducibly.
> 
> Patch attached.
>...

This should also fix the following FTBFS when the random part of 
the build path cylc-${random}/cylc-6.11.2 on a buildd contains an 
underscore (which is due to the "cylc-" incorrectly interpreted as 
version ${random}/cylc-6.11.2):

https://buildd.debian.org/status/package.php?p=cylc&suite=sid

...
I: NOTICE: Log filtering will replace 'build/cylc-EKa_gY/cylc-6.11.2' with 
'«PKGBUILDDIR»'
I: NOTICE: Log filtering will replace 'build/cylc-EKa_gY' with '«BUILDDIR»'
I: NOTICE: Log filtering will replace 
'var/lib/schroot/mount/sid-mipsel-sbuild-fd1fd3f4-d222-4d1c-b03b-5ff2aad6f8d4' 
with '«CHROOT»'
...
(./cylc-version.txt
! Missing $ inserted.
<inserted text> 
                $
l.1 EKa_
        gY/cylc-6.11.2
!  ==> Fatal error occurred, no output PDF file produced!
Transcript written on cug-pdf.log.
Makefile:66: recipe for target 'pdf/cug-pdf.pdf' failed
make[3]: *** [pdf/cug-pdf.pdf] Error 1
make[3]: Leaving directory '/«PKGBUILDDIR»/doc'
Makefile:23: recipe for target 'docs' failed
make[2]: *** [docs] Error 2
make[2]: Leaving directory '/«PKGBUILDDIR»'
debian/rules:8: recipe for target 'override_dh_auto_build' failed
make[1]: *** [override_dh_auto_build] Error 2
make[1]: Leaving directory '/«PKGBUILDDIR»'
debian/rules:5: recipe for target 'build-arch' failed
make: *** [build-arch] Error 2


>...
> --- a/debian/rules    2017-03-09 21:39:39.863360902 +0000
> --- b/debian/rules    2017-03-09 22:07:52.194043486 +0000
> @@ -1,5 +1,7 @@
>  #!/usr/bin/make -f
>  
> +VERSION = $(shell dpkg-parsechangelog --show-field Version)
>...

This seems to add the Debian revision to the version,
I have no idea whether this is good or bad here.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Reply via email to