Hi Peter, Thanks for your patches. I have committed everything up to "Canvas.pm: fix box offsets & text rotation" and pushed the commits, plus some of my own to the repo on Sourceforge.
At the moment, there are no unit tests for Gscan2pdf::Canvas, and as prefer to work test-driven, I would like a test which would fail without this patch. I am not 100% sure what problem your patch fixes, so would you mind constructing such a unit test? I would then have no problem committing the patch. The unit test would probably have to defined a page with some boxes before calling Gscan2pdf::Canvas->new() followed by canvas2hocr() and check the hocr output. Whilst you are at it, Gscan2pdf::Canvas has quite a few ProhibitMagicNumbers Perl::Critic overrides. If you know what the numbers mean, I would appreciate a patch replacing the numbers with descriptive Readonly variables. Thanks for your efforts Regards Jeff
signature.asc
Description: OpenPGP digital signature
