package xtrs tag 859751 + pending thanks At 2017-04-06T22:01:05+0200, Graham Inggs wrote: > Source: xtrs > Version: 4.9c-4 > Severity: wishlist > Tags: patch > > Hi Maintainer > > Welcome back!
Thanks! > According to the buildd log scanner [1], > > Issues found in current buildd logs for xtrs: > > W dpkg-buildflags-missing CPPFLAGS 27 (of 27), CFLAGS 27 (of 27), > LDFLAGS 5 (of 5) missing (amd64, arm64, armel, armhf, i386, mips, > mips64el, mipsel, powerpc, ppc64el, s390x) > > You can check this locally with the 'blhc' tool. After passing > CPPFLAGS, CFLAGS and LDFLAGS, as per the attached patch, the following > errors appeared: > > debug.c:518:10: error: format not a string literal and no format > arguments [-Werror=format-security] > printf(help_message); > ^~~~~~~~~~~~ > > dis.c: In function ‘disassemble’: > dis.c:2118:2: error: format not a string literal and no format > arguments [-Werror=format-security] > printf (code->name); > ^~~~~~ > > These are also fixed in the patch. Hi Graham. I already have these fixed in the 4.9d branch of the package; my upload sponsor advised me that including these (and other) changes violated the minimality constraints of the release freeze. I'm arranging sponsorship for an upload of 4.9d-2 right now, but you can preview the changes via the attachments. I see only one remaining issue: $ blhc xtrs_4.9d-2_amd64.build LDFLAGS missing (-Wl,-z,relro -Wl,-z,now): cc -o compile_rom compile_rom.o error.o load_cmd.o load_hex.o compile_rom is an utility internal to the build. It's not shipped and thus not subject to attacks. I'm considering adding an --ignore-line for it, but I need to figure out how to embed this information in the package itself so the buildd log scanner knows to use this flag itself. Please advise if you think the attachments don't address the issue. Regards, Branden
xtrs_4.9d-2.debian.tar.xz
Description: application/xz
Format: 3.0 (quilt) Source: xtrs Binary: xtrs Architecture: any Version: 4.9d-2 Maintainer: G. Branden Robinson <[email protected]> Homepage: http://www.tim-mann.org/xtrs.html Standards-Version: 3.9.8 Build-Depends: debhelper (>= 9), libncurses5-dev, libreadline-dev, libx11-dev, groff-base, bsdmainutils, po-debconf, html2text Package-List: xtrs deb contrib/otherosfs extra arch=any Checksums-Sha1: 42b1fc90246901456d29071421e838b545f39f0f 444499 xtrs_4.9d.orig.tar.gz e1a1ed4692d5cef24466980de5c2bce64fad905d 30912 xtrs_4.9d-2.debian.tar.xz Checksums-Sha256: 3985f2331e76198dfc027bc2afcd09a158d2bcad0348aeb4a4958a8fb99cf5c4 444499 xtrs_4.9d.orig.tar.gz 5466f8a110a0c6f7fc30017fb5bf36586195cffe0dc478b7cff315ec24dc32ad 30912 xtrs_4.9d-2.debian.tar.xz Files: 93868bed769c038bfae907375316bb2d 444499 xtrs_4.9d.orig.tar.gz 0ebf4eb05f566ec11cbce22ce3b5669d 30912 xtrs_4.9d-2.debian.tar.xz
signature.asc
Description: PGP signature
