Source: vis
Version: 0.3-1
Severity: important
Tags: upstream
Justification: fails to build from source

The build of vis for hurd-i386 (admittedly not a release architecture)
failed:

main.c: In function 'unicode_info':
main.c:1960:32: warning: format '%x' expects argument of type 'unsigned int', 
but argument 3 has type 'wchar_t {aka long int}' [-Wformat=]
    buffer_appendf(&info, "U+%04x ", wc);
                                ^
main.c: In function 'main':
main.c:2088:14: error: 'PIPE_BUF' undeclared (first use in this function)
     char buf[PIPE_BUF];
              ^~~~~~~~
main.c:2088:14: note: each undeclared identifier is reported only once for each 
function it appears in
In file included from sam.c:1604:0:
vis-cmds.c: In function 'file_open_dialog':
vis-cmds.c:359:19: error: 'PATH_MAX' undeclared (first use in this function)
  static char name[PATH_MAX];
                   ^~~~~~~~
[more references in vis.c and vis-lua.c]

Could you please take a look?  In the case of PATH_MAX, it would be
best to honor sysconf(_SC_PATH_MAX), but you could also hardcode a
fallback definition (traditionally 4096).  I presume the same goes for
PIPE_BUF, but I don't see a dedicated sysconf setting for it.

Thanks!

-- 
Aaron M. Ucko, KB1CJC (amu at alum.mit.edu, ucko at debian.org)
http://www.mit.edu/~amu/ | http://stuff.mit.edu/cgi/finger/?a...@monk.mit.edu

Reply via email to