Bug#351800: phpsysinfo: Config file produces notice, causes warnings with error_reporting = E_ALL

[Jonas Häggqvist]

Package: phpsysinfo
Version: 2.5.1-2
Severity: normal
Tags: patch

If you've changed PHP's error reporting to show notices, the config file
will produce a notice which causes problems later on:

Notice: Use of undefined constant suid - assumed 'suid' in
/etc/phpsysinfo/config.php on line 10

Warning: Cannot modify header information - headers already sent by
(output started at /etc/phpsysinfo/config.php:10) in
/usr/share/phpsysinfo/index.php on line 85

Warning: Cannot modify header information - headers already sent by
(output started at /etc/phpsysinfo/config.php:10) in
/usr/share/phpsysinfo/index.php on line 106

This is due to the lack of quotes around the value of hddtemp_avail in
/etc/phpsysinfo/config.php. The attached one-line patch fixes this
problem.


-- System Information:
Debian Release: testing/unstable
  APT prefers unstable
  APT policy: (990, 'unstable')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.14-2-k7
Locale: LANG=C, LC_CTYPE=en_DK.utf8 (charmap=ISO-8859-15) (ignored: LC_ALL set 
to da_DK.iso885915)

Versions of packages phpsysinfo depends on:
ii  apache [httpd]                1.3.34-2   versatile, high-performance HTTP s
ii  apache2-mpm-prefork [httpd]   2.0.55-4   traditional model for Apache2
ii  debconf [debconf-2.0]         1.4.70     Debian configuration management sy
ii  debianutils                   2.15.2     Miscellaneous utilities specific t
ii  libapache-mod-php4            4:4.4.2-1  server-side, HTML-embedded scripti
ii  libapache2-mod-php4           4:4.4.2-1  server-side, HTML-embedded scripti
ii  php4                          4:4.4.2-1  server-side, HTML-embedded scripti
ii  php4-cgi                      4:4.4.2-1  server-side, HTML-embedded scripti
ii  ucf                           2.005      Update Configuration File: preserv

phpsysinfo recommends no packages.

-- debconf information:
* phpsysinfo/bindmounts: false
* phpsysinfo/hddtemp: suid
* phpsysinfo/loadbar: true
* phpsysinfo/template: aq
* phpsysinfo/picklist: true
* phpsysinfo/lmsensors: true
* phpsysinfo/language: en
* phpsysinfo/mountpoints: true

diff -ru phpsysinfo-2.5.1.old/debian/phpsysinfo.postinst 
phpsysinfo-2.5.1/debian/phpsysinfo.postinst
--- phpsysinfo-2.5.1.old/debian/phpsysinfo.postinst     2006-02-07 
16:17:04.000000000 +0100
+++ phpsysinfo-2.5.1/debian/phpsysinfo.postinst 2006-02-07 16:17:24.000000000 
+0100
@@ -51,7 +51,7 @@
 \$default_template = "$template";
 \$loadbar = $loadbar;
 \$hide_picklist = $picklist;
-\$hddtemp_avail = $hddtemp;
+\$hddtemp_avail = "$hddtemp";
 
 ?>
 EOT