Package: release.debian.org
Severity: normal
User: release.debian....@packages.debian.org
Usertags: unblock

Hi,

Please unblock the package dsniff.  It FTBFS on machines with many cores
because the Makefile did not ensure the correct build order (see
#860611). The newly included patch fixes the problem.  The changelog
entry is:

dsniff (2.4b1+debian-25) unstable; urgency=medium

  * debian/control: Added myself to Uploaders.
  * Make sure libmissing.a is built before PROGS (Closes: #860611).

 -- Lukas Schwaighofer <lu...@schwaighofer.name>  Wed, 19 Apr 2017 20:15:27 
+0200

The source debdiff between the versions 2.4b1+debian-24 and
2.4b1+debian-25 is attached.

unblock dsniff/2.4b1+debian-25


Thank you
Lukas Schwaighofer
diff -Nru dsniff-2.4b1+debian/debian/changelog dsniff-2.4b1+debian/debian/changelog
--- dsniff-2.4b1+debian/debian/changelog	2017-03-13 18:34:19.000000000 +0100
+++ dsniff-2.4b1+debian/debian/changelog	2017-04-19 21:55:26.000000000 +0200
@@ -1,3 +1,10 @@
+dsniff (2.4b1+debian-25) unstable; urgency=medium
+
+  * debian/control: Added myself to Uploaders.
+  * Make sure libmissing.a is built before PROGS (Closes: #860611).
+
+ -- Lukas Schwaighofer <lu...@schwaighofer.name>  Wed, 19 Apr 2017 20:15:27 +0200
+
 dsniff (2.4b1+debian-24) unstable; urgency=medium
 
   * Fix FTCBFS: Pass triplet-prefixed CC to configure.
diff -Nru dsniff-2.4b1+debian/debian/control dsniff-2.4b1+debian/debian/control
--- dsniff-2.4b1+debian/debian/control	2017-03-06 11:17:50.000000000 +0100
+++ dsniff-2.4b1+debian/debian/control	2017-04-19 21:55:26.000000000 +0200
@@ -2,7 +2,7 @@
 Section: net
 Priority: optional
 Maintainer: Debian Security Tools Packaging Team <pkg-security-t...@lists.alioth.debian.org>
-Uploaders: Marcos Fouces <mfou...@yahoo.es>
+Uploaders: Marcos Fouces <mfou...@yahoo.es>, Lukas Schwaighofer <lu...@schwaighofer.name>
 Standards-Version: 3.9.8
 Build-Depends: libdb-dev (>= 4.7), libpcap0.8-dev, libnids-dev, libssl-dev, libxmu-dev, libnet1-dev, debhelper (>= 10)
 Homepage: http://www.monkey.org/~dugsong/dsniff/
diff -Nru dsniff-2.4b1+debian/debian/patches/34_make-sure-libmissing.a-is-built-before-PROGS.patch dsniff-2.4b1+debian/debian/patches/34_make-sure-libmissing.a-is-built-before-PROGS.patch
--- dsniff-2.4b1+debian/debian/patches/34_make-sure-libmissing.a-is-built-before-PROGS.patch	1970-01-01 01:00:00.000000000 +0100
+++ dsniff-2.4b1+debian/debian/patches/34_make-sure-libmissing.a-is-built-before-PROGS.patch	2017-04-19 21:55:26.000000000 +0200
@@ -0,0 +1,90 @@
+From: Lukas Schwaighofer <lu...@schwaighofer.name>
+Date: Wed, 19 Apr 2017 10:12:11 +0200
+Subject: make sure libmissing.a is built before PROGS
+
+Add libmissing.a as a dependency to each of the PROGS to ensure it is
+built before them (fixes FTBFS in some environments).
+
+Closes: #860611
+---
+ Makefile.in | 32 ++++++++++++++++----------------
+ 1 file changed, 16 insertions(+), 16 deletions(-)
+
+diff --git a/Makefile.in b/Makefile.in
+index 1b1621d..ada5412 100644
+--- a/Makefile.in
++++ b/Makefile.in
+@@ -75,7 +75,7 @@ CONFIGS	= dsniff.magic dsniff.services dnsspoof.hosts
+ .c.o:
+ 	$(CC) $(CFLAGS) $(INCS) -c $(srcdir)/$*.c
+ 
+-all: libmissing.a $(PROGS)
++all: $(PROGS)
+ 
+ mount.c: mount.x
+ 	rpcgen -h mount.x -o mount.h
+@@ -92,49 +92,49 @@ libmissing.a: $(LIBOBJS)
+ 	ar -cr $@ $(LIBOBJS)
+ 	$(RANLIB) $@
+ 
+-dsniff: $(HDRS) $(SRCS) $(OBJS)
++dsniff: $(HDRS) $(SRCS) $(OBJS) libmissing.a
+ 	$(CC) $(LDFLAGS) -o $@ $(OBJS) $(LIBS) $(NIDSLIB) $(PCAPLIB) $(LNETLIB) $(DBLIB) $(SSLLIB)
+ 
+-arpspoof: arpspoof.o arp.o
++arpspoof: arpspoof.o arp.o libmissing.a
+ 	$(CC) $(LDFLAGS) -o $@ arpspoof.o arp.o $(LIBS) $(PCAPLIB) $(LNETLIB)
+ 
+-dnsspoof: dnsspoof.o pcaputil.o
++dnsspoof: dnsspoof.o pcaputil.o libmissing.a
+ 	$(CC) $(LDFLAGS) -o $@ dnsspoof.o pcaputil.o $(LIBS) $(PCAPLIB) $(LNETLIB)
+ 
+-filesnarf: nfs_prot.o filesnarf.o pcaputil.o rpc.o
++filesnarf: nfs_prot.o filesnarf.o pcaputil.o rpc.o libmissing.a
+ 	$(CC) $(LDFLAGS) -o $@ filesnarf.o nfs_prot.o pcaputil.o rpc.o $(LIBS) $(NIDSLIB) $(PCAPLIB) $(LNETLIB)
+ 
+-macof: macof.o
++macof: macof.o libmissing.a
+ 	$(CC) $(LDFLAGS) -o $@ macof.o $(LIBS) $(PCAPLIB) $(LNETLIB)
+ 
+-mailsnarf: mailsnarf.o buf.o pcaputil.o
++mailsnarf: mailsnarf.o buf.o pcaputil.o libmissing.a
+ 	$(CC) $(LDFLAGS) -o $@ mailsnarf.o buf.o pcaputil.o $(LIBS) $(NIDSLIB) $(PCAPLIB) $(LNETLIB)
+ 
+-msgsnarf: msgsnarf.o buf.o pcaputil.o
++msgsnarf: msgsnarf.o buf.o pcaputil.o libmissing.a
+ 	$(CC) $(LDFLAGS) -o $@ msgsnarf.o buf.o pcaputil.o $(LIBS) $(NIDSLIB) $(PCAPLIB) $(LNETLIB)
+ 
+-sshmitm: sshmitm.o buf.o hex.o record.o ssh.o sshcrypto.o
++sshmitm: sshmitm.o buf.o hex.o record.o ssh.o sshcrypto.o libmissing.a
+ 	$(CC) $(LDFLAGS) -o $@ sshmitm.o buf.o hex.o record.o ssh.o sshcrypto.o $(LIBS) $(LNETLIB) $(DBLIB) $(SSLLIB)
+ 
+-sshow: sshow.o pcaputil.o
++sshow: sshow.o pcaputil.o libmissing.a
+ 	$(CC) $(LDFLAGS) -o $@ sshow.o pcaputil.o $(LIBS) $(NIDSLIB) $(PCAPLIB) $(LNETLIB)
+ 
+-tcpkill: tcpkill.o pcaputil.o
++tcpkill: tcpkill.o pcaputil.o libmissing.a
+ 	$(CC) $(LDFLAGS) -o $@ tcpkill.o pcaputil.o $(LIBS) $(PCAPLIB) $(LNETLIB)
+ 
+-tcpnice: tcpnice.o pcaputil.o
++tcpnice: tcpnice.o pcaputil.o libmissing.a
+ 	$(CC) $(LDFLAGS) -o $@ tcpnice.o pcaputil.o $(LIBS) $(PCAPLIB) $(LNETLIB)
+ 
+-tcphijack: tcphijack.o pcaputil.o
++tcphijack: tcphijack.o pcaputil.o libmissing.a
+ 	$(CC) $(LDFLAGS) -o $@ tcphijack.o pcaputil.o $(LIBS) $(PCAPLIB) $(LNETLIB)
+ 
+-urlsnarf: urlsnarf.o base64.o buf.o pcaputil.o
++urlsnarf: urlsnarf.o base64.o buf.o pcaputil.o libmissing.a
+ 	$(CC) $(LDFLAGS) -o $@ urlsnarf.o base64.o buf.o pcaputil.o $(LIBS) $(NIDSLIB) $(PCAPLIB) $(LNETLIB)
+ 
+-webmitm: webmitm.o base64.o buf.o decode_http.o record.o
++webmitm: webmitm.o base64.o buf.o decode_http.o record.o libmissing.a
+ 	$(CC) $(LDFLAGS) -o $@ webmitm.o base64.o buf.o decode_http.o record.o $(LIBS) $(LNETLIB) $(DBLIB) $(SSLLIB)
+ 
+-webspy: webspy.o base64.o buf.o remote.o
++webspy: webspy.o base64.o buf.o remote.o libmissing.a
+ 	$(CC) $(LDFLAGS) -o $@ webspy.o base64.o buf.o remote.o $(LIBS) $(NIDSLIB) $(PCAPLIB) $(LNETLIB) $(X11LIB)
+ 
+ install:
diff -Nru dsniff-2.4b1+debian/debian/patches/series dsniff-2.4b1+debian/debian/patches/series
--- dsniff-2.4b1+debian/debian/patches/series	2017-03-06 11:17:50.000000000 +0100
+++ dsniff-2.4b1+debian/debian/patches/series	2017-04-19 21:55:26.000000000 +0200
@@ -31,3 +31,4 @@
 31_sysconf_clocks.patch
 32_rpc_segfault.patch
 33_sshcrypto_DES.patch
+34_make-sure-libmissing.a-is-built-before-PROGS.patch

Attachment: pgpVWVtDSRGpg.pgp
Description: OpenPGP digital signature

Reply via email to