Source: symfony Version: 2.8.7+dfsg-1.2 Severity: serious Tags: patch upstream fixed-upstream
Hi, I noticed that symfony now FTBFS after the upload of php7.0 7.0.18-1, with the following error in the test suite: > 1) Symfony\Component\VarDumper\Tests\CliDumperTest::testThrowingCaster > Failed asserting that format description matches text. > --- Expected > +++ Actual > @@ @@ > stream resource {@239 > -%Awrapper_type: "PHP" > + timed_out: false > + blocked: true > + eof: false > + wrapper_type: "PHP" > stream_type: "MEMORY" > - mode: "%s+b" > + mode: "w+b" > unread_bytes: 0 > seekable: true > uri: "php://memory" > -%Aoptions: [] > - ⚠: Symfony\Component\VarDumper\Exception\ThrowingCasterException {#%d > + options: [] > + ⚠: Symfony\Component\VarDumper\Exception\ThrowingCasterException {#411 > #message: "Unexpected Exception thrown from a caster: Foobar" > -trace: { > - %d. __TwigTemplate_VarDumperFixture_u75a09->doDisplay() ==> new > Exception(): { > + 22. __TwigTemplate_VarDumperFixture_u75a09->doDisplay() ==> new > Exception(): { > src: { > - %sTwig.php:19: """ > + > /<<BUILDDIR>>/symfony-2.8.7+dfsg/src/Symfony/Component/VarDumper/Tests/Fixtures/Twig.php:19: > """ > > @@ @@ > } > - %d. Twig_Template->displayWithErrorHandling() ==> > __TwigTemplate_VarDumperFixture_u75a09->doDisplay(): { > + 21. Twig_Template->displayWithErrorHandling() ==> > __TwigTemplate_VarDumperFixture_u75a09->doDisplay(): { > src: { > - %sTemplate.php:%d: """ > + /usr/share/php/Twig/Template.php:381: """ > > @@ @@ > } > - %d. Twig_Template->display() ==> > Twig_Template->displayWithErrorHandling(): { > + 20. Twig_Template->display() ==> > Twig_Template->displayWithErrorHandling(): { > src: { > - %sTemplate.php:%d: """ > + /usr/share/php/Twig/Template.php:355: """ > > @@ @@ > } > - %d. Twig_Template->render() ==> Twig_Template->display(): { > + 19. Twig_Template->render() ==> Twig_Template->display(): { > src: { > - %sTemplate.php:%d: """ > + /usr/share/php/Twig/Template.php:366: """ > > @@ @@ > } > - %d. %slosure%s() ==> Twig_Template->render(): { > + 18. Symfony\Component\VarDumper\Tests\CliDumperTest->{closure}() ==> > Twig_Template->render(): { > src: { > - %sCliDumperTest.php:189: """ > - }\n > - };'),\n > - ));\n > + > /<<BUILDDIR>>/symfony-2.8.7+dfsg/src/Symfony/Component/VarDumper/Tests/CliDumperTest.php:183: > """ > + $cloner->addCasters(array(\n > + ':stream' => eval('return function () use ($twig) {\n > + try {\n > """ > } > } > } > } > } > > /<<BUILDDIR>>/symfony-2.8.7+dfsg/src/Symfony/Component/VarDumper/Tests/CliDumperTest.php:277 The difference is that the line number for CliDumperTest.php right at the end is no longer correct, and has some different code after it. Upstream fixed this already[1,2], and these changes are also in #863441, but there are other changes not required for PHP 7.0, hence the separate bug. I am happy to NMU again with just the changes needed, and will do so if I do not hear anything soon, as the release is approaching and this will otherwise become a stretch-will-remove bug. Regards, James [1] https://github.com/symfony/symfony/commit/3672c01e3c7182888a42b74e2864a20e21cfe7f5 [2] https://github.com/symfony/symfony/commit/6ef78ec55317ac473fa045706244ef1f97d4b2de (only the change to CliDumperTest.php)