Package: libvirt
Version: 3.0.0-4
Severity: minor

Hi,
similar to my other bug report today this came to me initially by being
made aware of obsolete conffiles. Due to that in the context of this bug I
found that some conffiles are no more shipped but were in the past.

The file is used by virt-admin and referenced by its man page
"libvirt-admin.conf".
I want to follow Debian with that file, but to be honest I don't easily see
"how" it was added in the past.
In particular I was puzzled at first by Xenial 1.3.1 [1] including it in
the package, but Debian 1.3.1 [2] did not.

But then I compared that to libvirt.conf from libvirt-clients package.
That is part of the same "conf_DATA = libvirt.conf libvirt-admin.conf" in
src/Makefile.am.
That is installed via debian/libvirt-clients.install.
This is working for Debian and Ubuntu the same way.

So it seems in the past Ubuntu fixed the installation of that file (as seen
in [1]) but it was dropped when we started to realign with Debians
packaging scheme.
Lets not do this again and fix it in Debian this time as it should have
been done initially.

Since virt-admin is part of libvirt-clients lets place it there.

Attaching a patch on top of latest Debian packaging that fixes the issue in
my local builds - buildlog at [3].

Note: Since the program works fine without the file - it is just about
tuning defaults, but being a bug more than a feature request I decided for
"minor" severity.

[1]:
https://launchpadlibrarian.net/319869772/buildlog_ubuntu-xenial-amd64.libvirt_1.3.1-1ubuntu10.10_BUILDING.txt.gz
[2]:
https://buildd.debian.org/status/fetch.php?pkg=libvirt&arch=amd64&ver=1.3.1-1&stamp=1453477524&raw=0
[3]: http://paste.ubuntu.com/24705667/

-- 
Christian Ehrhardt
Software Engineer, Ubuntu Server
Canonical Ltd
From c53802d4830b92e0f9f48bb4689b7728025b2286 Mon Sep 17 00:00:00 2001
From: Christian Ehrhardt <[email protected]>
Date: Mon, 29 May 2017 17:15:26 +0200
Subject: [PATCH] Provide libvirt-admin.conf

Since virt-admin uses and refers to this conffile add the
upstream default config to libvirt-clients package.

Signed-off-by: Christian Ehrhardt <[email protected]>
---
 debian/libvirt-clients.install | 1 +
 1 file changed, 1 insertion(+)

diff --git a/debian/libvirt-clients.install b/debian/libvirt-clients.install
index 84fab60..358391a 100644
--- a/debian/libvirt-clients.install
+++ b/debian/libvirt-clients.install
@@ -1,3 +1,4 @@
 usr/bin/*
 usr/share/man/man1/*
 etc/libvirt/libvirt.conf
+etc/libvirt/libvirt-admin.conf
-- 
2.7.4

Reply via email to