On Tue, May 23, 2017 at 09:55:11AM +0200, Michael Stapelberg wrote:
> I’m not subscribed, so please keep me cc'ed :).
 
ok!

> > ok, so only parsing 4 suites… how long did these commands run?
> 294,21s user 212,64s system 30% cpu 27:36,09 total
 
ok, so minutes rather than hours… 

> > hehe, nice! got an example?
> Sure:
> https://manpages.debian.org/unstable/postgresql-client-9.6/pg_dump.1.en.html
> https://manpages.debian.org/unstable/vis/vi.1.en.html
 
those are the links to other version, languages and conflicting commands?

> > sounds good, how often would you like to run it?
> Once a day would be sufficient, I think.
 
cool.

> Since piuparts.d.o is running on jessie, we’ll need to use golang-go 1.7
> from jessie-backports, please :)
 
ok, I'll request this once we got closer… (see below)

> Great. Find a patch attached. Note that it’s untested, as golang-go is not
> yet installed and I lack permission to run as piupartsm. I’m not sure what
> your development process is for changes like this, but feel free to fix up
> the patch as necessary.
 
process wise it's fine to just install it and then fix it up…

but… 

+export GOPATH=$(mktemp -d)
+trap 'rm -rf "${GOPATH}"' TERM INT EXIT QUIT
+go get -u github.com/Debian/debiman/cmd/debiman-piuparts-distill
+export PATH=${GOPATH}/bin:$PATH

from distill_alternatives_log from your patch makes me uneasy… because, for a
start, how is the code authenticated?

Also, I don't expect debiman-piuparts-distill to change very often, do you?

> Sure. I’ll add some commentary, and I’m also happy to explain any details —
> just ask.
 
thanks, the code is much nicer to read now! :)

> It could continue living in github.com/Debian/debiman, or we could move it
> to piuparts. The advantage of keeping it in github.com/Debian/debiman is
> that we don’t need to duplicate code between different git repositories.

does the code need to live in github.com/Debian/debiman at all? One copy
in the piuparts repo should be enough, or?


-- 
cheers,
        Holger

Attachment: signature.asc
Description: Digital signature

Reply via email to