Hi Daniel,

Daniel Gnoutcheff wrote:
> /usr/share/xen-tools/common/50-setup-hostname-deb is supposed to reload
> dnsmasq (if installed and running) after adding a line to /etc/hosts.
> However, this does not happen on my stretch system, and dnsmasq doesn't
> pick up these entries until I reload it manually.
> 
> I suspect this is because setup-hostname-deb hardcodes the wrong pidfile
> path:
> 
> > if [ -e /var/run/dnsmasq.pid ]; then
> > 
> >     logMessage Allowing DNSMasq to restart.
> >     kill -s HUP `cat /var/run/dnsmasq.pid`
> > fi
> 
> The correct path seems to be /run/dnsmasq/dnsmasq.pid.

Thanks for the bug report.

Since these snippets should be rather generic I wonder if should be
replaced with something like this:

for pidfile in {,/var}/run/{,dnsmasq/}dnsmasq.pid; do
    if [ -e $pidfile ]; then
        logMessage Trying to restart DNSMasq via $pidfile.
        kill -s HUP `cat $pidfile`
    fi
done

(bash-syntax, the final script should be POSIX compatible, hence no
curly brace expansion possible.)

                Regards, Axel
-- 
 ,''`.  |  Axel Beckert <a...@debian.org>, http://people.debian.org/~abe/
: :' :  |  Debian Developer, ftp.ch.debian.org Admin
`. `'   |  4096R: 2517 B724 C5F6 CA99 5329  6E61 2FF9 CD59 6126 16B5
  `-    |  1024D: F067 EA27 26B9 C3FC 1486  202E C09E 1D89 9593 0EDE

Reply via email to