Package: libspice-client-glib-2.0-8
Version: 0.33-3.3
Severity: normal

Dear Maintainer,

The spice-gtk source packages now Build-Depends on:
  gstreamer1.0-tools,
  gstreamer1.0-plugins-bad,
  gstreamer1.0-plugins-base,
  gstreamer1.0-plugins-good,
  gstreamer1.0-libav,

However in reality it does not need any of these packages to build.
These dependencies were wrongly added as a result of bug 841932 which
mentions these configure warnings:

configure: WARNING: Cannot verify that the required runtime GStreamer 1.0 
elements are present because gst-inspect-1.0 is missing

configure: WARNING: The audioconvert audioresample appsink GStreamer element(s) 
are missing. You should be able to find them in the gst-plugins-base 1.0 
package.
configure: WARNING: The autoaudiosrc GStreamer element(s) are missing. You 
should be able to find them in the gst-plugins-good 1.0 package.
configure: WARNING: The GStreamer 1.0 audio backend can be built but may not 
work.

configure: WARNING: The appsrc videoconvert appsink GStreamer element(s) are 
missing. You should be able to find them in the gst-plugins-base 1.0 package.
configure: WARNING: The jpegdec vp8dec GStreamer element(s) are missing. You 
should be able to find them in the gst-plugins-good 1.0 package.i
configure: WARNING: The h264parse GStreamer element(s) are missing. You should 
be able to find them in the gst-plugins-bad 1.0 package.
configure: WARNING: The avdec_h264 GStreamer element(s) are missing. You should 
be able to find them in the gstreamer-libav 1.0 package.
configure: WARNING: The GStreamer video decoder can be built but may not work.

These messages explicitly mention that the audio and video
GStreamer-based decoders can be built without these plugins. So the
above packages should not be Build-Depends.

The only reason why the configure script has these warnings is to
remind Spice developers that if they plan on using or testing the
GStreamer decoders they will also need one or more of these plugins.



Which brings me to the second issue in the spice-gtk source package,
libspice-client-glib-2.0-8 now Depends on:
  gstreamer1.0-plugins-bad, gstreamer1.0-plugins-base,
  gstreamer1.0-plugins-good,
  gstreamer1.0-libav

This is also incorrect.

The Spice client works just fine without these plugins, it will just
not be able to use GStreamer if the corresponding plugins are missing.

More precisely it will check whether these GStreamer plugins are present
at runtime and will not advertise support for a video format impacted
by a missing GStreamer plugin. This runtime negotiation ensures that the
server will not send video in a format the client cannot handle.

Also note that the Spice client still has the built-in MJPEG video
decoder (which does not depend on GStreamer) and thus will still be able
to perform video streaming even if all the GStreamer plugins are
missing.

So these should be Suggests or Recommends at most.
(I don't have a strong opinion on either option)


-- System Information:
Debian Release: 9.0
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'stable')
Architecture: amd64
 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.9.0-2-amd64 (SMP w/8 CPU cores)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages libspice-client-glib-2.0-8 depends on:
ii  gstreamer1.0-libav                1:1.10.4-dmo1
ii  gstreamer1.0-plugins-bad          1:1.10.4-dmo2
ii  gstreamer1.0-plugins-base         1.10.4-1+ma1
ii  gstreamer1.0-plugins-good         1.10.4-1
ii  libc6                             2.24-10
ii  libcacard0                        1:2.5.0-3
ii  libglib2.0-0                      2.50.3-2+ma1
ii  libgstreamer-plugins-base1.0-0    1.10.4-1+ma1
ii  libgstreamer1.0-0                 1.10.4-1+ma1
ii  libjpeg62-turbo                   1:1.5.1-2
ii  liblz4-1                          0.0~r131-2+b1
ii  libopus0                          1.2~alpha2-1
ii  libphodav-2.0-0                   2.1-1
ii  libpixman-1-0                     0.34.0-1
ii  libpulse-mainloop-glib0           10.0-1
ii  libpulse0                         10.0-1
ii  libsasl2-2                        2.1.27~101-g0780600+dfsg-3
ii  libsoup2.4-1                      2.56.0-2
ii  libssl1.1                         1.1.0e-2
ii  libusb-1.0-0                      2:1.0.21-1
ii  libusbredirhost1                  0.7.1-1
ii  libusbredirparser1                0.7.1-1
ii  spice-client-glib-usb-acl-helper  0.33-3.3
ii  zlib1g                            1:1.2.8.dfsg-5

libspice-client-glib-2.0-8 recommends no packages.

libspice-client-glib-2.0-8 suggests no packages.

-- no debconf information

Reply via email to