Control: tag -1 pending Hi!
On Mon, 2017-06-19 at 14:05:15 +0100, James Cowgill wrote: > Control: tags -1 patch > On 19/06/17 09:24, Adrian Bunk wrote: > > FAIL: nlist > > =========== > > > > nlist: nlist.c:70: main: Assertion `rc == 0' failed. > > FAIL nlist (exit status: 134) > > I've attached some patches which should fix this for mips64el and > ppc64el (and probably ppc64). As far as I can tell, nlist has never > worked on these architectures. > > The ppc64el patch fixes 2 errors in local-elf.h: > * ppc64el defines both __powerpc__ and __powerpc64__ but since the > __powerpc64__ #elif is below the __powerpc__ one, it will never be hit. > * Both assumed that powerpc* was big-endian. > > The mips64el patch adds a check for _MIPS_SIM inside the __mips__ #elif > to detect mips64el and use ELFCLASS64 in that case. Note that we can't > use defined(__mips64) here because that is also defined when the n32 ABI > is in use, which uses ELFCLASS32. I also checked this one yesterday, but the problem was not immediately obvious from the build log. James, thanks much for tracking it down and providing patches! I've merged them locally, and will include them in the new upstream release later today. I checked the hurd-i386 failure yesterday, which seems to be related to argv and envp's strings not being allocated in contiguous memory, which looks like a "regression" or change of behavior. If I cannot get this fixed quickly today, I'll just fix the ones for Linux and postpone this one for later. Thanks, Guillem
