Control: tag -1 + pending Hi,
Rob Browning wrote:
> We'd like to remove emacs24 from the archive, so please try to upgrade
> to emacs25, or add optional support for emacs25 as soon as you can.
I've tested the sass-mode.el with Emacs 25 from Unstable and at least
all the test suite .sass files of the sass project seem to render fine
under Emacs 25.
The compilation on installations though throws some emacs version
related warnings, but they all seem to come from the haml-elisp
package, a dependency of sass-elisp:
---------------------------------------------------------------------------
[…]ache/pbuilder/result # dpkg -i sass-elisp_3.0.15-4.2_all.deb
(Reading database ... 1422694 files and directories currently installed.)
Preparing to unpack sass-elisp_3.0.15-4.2_all.deb ...
Remove sass-elisp for emacs25
install/sass-elisp: Handling removal of emacsen flavor emacs25
install/sass-elisp: purging byte-compiled files for emacs25
Unpacking sass-elisp (3.0.15-4.2) over (3.0.15-4.2) ...
Setting up sass-elisp (3.0.15-4.2) ...
Install emacsen-common for emacs25
emacsen-common: Handling install of emacsen flavor emacs25
Install haml-elisp for emacs25
install/haml-elisp: Handling install of emacsen flavor emacs25
install/haml-elisp: byte-compiling for emacs25
Installing source code for emacs25
In haml-fontify-region:
haml-mode.el:121:53:Warning: value returned from (< emacs-major-version 24) is
unused
In end of data:
haml-mode.el:878:1:Warning: the function ‘aget’ is not known to be defined.
Install sass-elisp for emacs25
install/sass-elisp: Handling install of emacsen flavor emacs25
install/sass-elisp: byte-compiling for emacs25
Installing source code for emacs25
---------------------------------------------------------------------------
> For example, assuming the package works with emacs25, a dependency like
>
> emacs25-nox | emacs25 | emacs24 | ...
>
> should suffice.
I went with "emacs25 | emacs24 | emacs23" since emacs25-nox "Provides:
emacs25".
> If you don't have time to handle this yourself, we'd be happy to try to
> assist with an NMU (please let us know).
I've prepared a non-maintainer upload which fixes this and some more
(IMHO clearly undisputed) issues with the package (most of them were
reported by lintian) and have uploaded it to DELAYED/14 just now.
Gastón, Rob: Please tell me in case I should fast-forward this NMU or
if you spot any issues with it.
Here's the full source debdiff:
diff -Nru sass-elisp-3.0.15/debian/changelog sass-elisp-3.0.15/debian/changelog
--- sass-elisp-3.0.15/debian/changelog 2017-03-04 16:55:25.000000000 +0100
+++ sass-elisp-3.0.15/debian/changelog 2017-06-30 16:09:09.000000000 +0200
@@ -1,3 +1,18 @@
+sass-elisp (3.0.15-4.2) unstable; urgency=medium
+
+ * Non-maintainer upload.
+ * Add emacs25 to list of supported versions. (Closes: #852099)
+ * Update Vcs-* headers to current default locations.
+ * Drop "Section: lisp" from binary stanza. It's already in the source
+ stanza.
+ * Declare debian/copyright to be compatible with version 1.0 of
+ DEP-5. No other changes were necessary.
+ * Fix "ERROR: sass-elisp is broken - called emacs-package-install as a
+ new-style add-on, but has no compat file." by adding a dependency on
+ emacsen-common >= 2.0.8 and a debian/sass-elisp.emacsen-compat file.
+
+ -- Axel Beckert <[email protected]> Fri, 30 Jun 2017 16:09:09 +0200
+
sass-elisp (3.0.15-4.1) unstable; urgency=medium
* Non-maintainer upload.
diff -Nru sass-elisp-3.0.15/debian/control sass-elisp-3.0.15/debian/control
--- sass-elisp-3.0.15/debian/control 2017-03-04 16:55:25.000000000 +0100
+++ sass-elisp-3.0.15/debian/control 2017-06-30 15:55:25.000000000 +0200
@@ -5,14 +5,13 @@
Build-Depends: debhelper (>= 8.0.0), quilt
Standards-Version: 3.9.3
Homepage: http://sass-lang.com/
-Vcs-Git: git://git.debian.org/collab-maint/sass-elisp.git
-Vcs-Browser: http://git.debian.org/?p=collab-maint/sass-elisp.git;a=summary
+Vcs-Git: https://anonscm.debian.org/git/collab-maint/sass-elisp.git
+Vcs-Browser: https://anonscm.debian.org/git/collab-maint/sass-elisp.git
Package: sass-elisp
-Section: lisp
Architecture: all
Recommends: ruby-sass
-Depends: ${misc:Depends}, emacs23 | emacs24, haml-elisp (>= 1:3.0.15-5)
+Depends: ${misc:Depends}, emacs25 | emacs24 | emacs23, haml-elisp (>=
1:3.0.15-5), emacsen-common (>= 2.0.8)
Description: Emacs Lisp mode for the Sass markup language
This package provides the emacs-lisp for syntax-highlighting Sass
- mode for emacs23 or emacs24.
+ mode for emacs23, emacs24 or emacs25.
diff -Nru sass-elisp-3.0.15/debian/copyright sass-elisp-3.0.15/debian/copyright
--- sass-elisp-3.0.15/debian/copyright 2017-03-04 16:55:25.000000000 +0100
+++ sass-elisp-3.0.15/debian/copyright 2017-06-30 15:08:32.000000000 +0200
@@ -1,4 +1,4 @@
-Format: http://dep.debian.net/deps/dep5
+Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Upstream-Name: sass-mode.el
Source: http://github.com/nex3/sass/tree/master
diff -Nru sass-elisp-3.0.15/debian/sass-elisp.emacsen-compat
sass-elisp-3.0.15/debian/sass-elisp.emacsen-compat
--- sass-elisp-3.0.15/debian/sass-elisp.emacsen-compat 1970-01-01
01:00:00.000000000 +0100
+++ sass-elisp-3.0.15/debian/sass-elisp.emacsen-compat 2017-06-30
15:57:27.000000000 +0200
@@ -0,0 +1 @@
+0
diff -Nru sass-elisp-3.0.15/debian/sass-elisp.emacsen-install
sass-elisp-3.0.15/debian/sass-elisp.emacsen-install
--- sass-elisp-3.0.15/debian/sass-elisp.emacsen-install 2017-03-04
16:55:25.000000000 +0100
+++ sass-elisp-3.0.15/debian/sass-elisp.emacsen-install 2017-06-30
14:49:23.000000000 +0200
@@ -1,10 +1,10 @@
#!/bin/sh
set -e
SRC_FILE="sass-mode.el"
-# Right now only emacs23 and emacs24 are supported. If the future brings
support
+# Right now only emacs23 to emacs25 are supported. If the future brings support
# for other emacsen, we can keep this same logic - just update this
# regex
-SUPPORTED_EMACSEN="^emacs2[34]$"
+SUPPORTED_EMACSEN="^emacs2[3-5]$"
FLAVOR="$1"
if echo $FLAVOR | egrep -vq $SUPPORTED_EMACSEN; then
Regards, Axel
--
,''`. | Axel Beckert <[email protected]>, http://people.debian.org/~abe/
: :' : | Debian Developer, ftp.ch.debian.org Admin
`. `' | 4096R: 2517 B724 C5F6 CA99 5329 6E61 2FF9 CD59 6126 16B5
`- | 1024D: F067 EA27 26B9 C3FC 1486 202E C09E 1D89 9593 0EDE
signature.asc
Description: Digital signature
