Am 03.07.2017 um 12:51 schrieb Emmanuel Bourg: > Le 3/07/2017 à 11:48, Markus Koschany a écrit : > >> So if I understand correctly all pure javahelper packages are safe as >> long as they have defined the encoding already? > > Yes, but I'm under the impression that no javahelper based package does > so (a code search on "JH_JAVADOC_OPTS" returns only javatools).
It's been a long time since I had to override the encoding with Javahelper. I can't even remember in how many packages I had to specify the encoding. But in general the goal is clear. The default encoding of jh_build should be UTF-8 and it should be possible to override it either with passing the encoding to jh_build directly or via an environment variable like JH_JAVADOC_OPTS. Maybe let's start with an upload to experimental and we try it on some guinea pig javahelper packages first. >> I don't understand the maven-debian-helper case though. The >> project.build.sourceEncoding in my maven.properties file won't override >> the new default UTF-8 value anymore? > > I'm not sure about that. I just know that the command line parameter > overrides the property in pom.xml. > > Note that if maven.properties could override the property set by > maven-debian-helper, we would have many cases where maven-debian-helper > sets the encoding to UTF-8, the pom.xml sets the encoding to ISO-8859-1 > (but is ignored), and we would have to add the encoding in > debian/maven.properties to ensure it still compiles. That would be > counter-productive since upstream already configured the encoding properly. Maybe the logic should be: IF NOT EXIST property encoding in pom.xml or (IF EXIST debian/maven.properties AND debian/maven.properties CONTAINS STRING project.build.sourceEncoding) SET encoding to UTF-8 Anyway I suggest we start with one of them and don't try to fix both at the same time. I have no problem with fixing some packages if we succeed on defaulting to UTF-8 encoding and at the same time find a way to respect existing overrides.
signature.asc
Description: OpenPGP digital signature
