tag 854327 +patch
thanks

hi,

> The real fix is of course for consolekit module to exit gracefully if
> consolekit is not installed (the logind module does the same). But I
> have no idea how to do that. Would it be enough to check the dbus
> error name? I can't find a canonical list of error names though....

I think it's a bad idea to load the module in the first place if it is
not supposed to be loaded at all.

As pulseaudio is *modular* why do we need to deliver the console-kit
module with pulseaudio itself in the first place?

The default.pa configuration uses ifdef style module loading, if the so
file is not present theres nothing to be loaded.

.ifexists module-console-kit.so
load-module module-console-kit
.endif

1. ConsoleKit is not maintained and recommends systemd-logind [1]

2. The majority of Debian users should be using systemd-logind now
    where module-console-kit is being ignored.

3. Others like Felipe and me may neither use systemd nor console-kit
    and will end up with PA not willing to load at all

4. Only users having ConsoleKit installed need the module.

=> split out the module into a pulseaudio-module-consolekit package
    and add a Depends: consolekit

build and use-tested patch splitting out the console-kit module attached

bye

[1] https://www.freedesktop.org/wiki/Software/ConsoleKit/
diff -Nrup a/debian/control b/debian/control
--- a/debian/control	2017-06-15 10:07:30.000000000 +0000
+++ b/debian/control	2017-07-08 12:15:06.068749893 +0000
@@ -122,6 +122,19 @@ Description: PulseAudio ESD compatibilit
  many useful applications. It enables a PulseAudio sound server to
  fully replace ESD.
 
+Package: pulseaudio-module-consolekit
+Architecture: any
+Depends: ${shlibs:Depends}, ${misc:Depends}, consolekit (>= 0.4.6)
+Description: ConsoleKit module for PulseAudio sound server
+ PulseAudio, previously known as Polypaudio, is a sound server for POSIX and
+ WIN32 systems. It is a drop in replacement for the ESD sound server with
+ much better latency, mixing/re-sampling quality and overall architecture.
+ .
+ This module enables PulseAudio to dynamically give the current user access
+ to the soundcard(s) when using ConsoleKit user session switching.
+ .
+ The module is called module-console-kit.
+
 Package: pulseaudio-module-zeroconf
 Architecture: any
 Depends: ${shlibs:Depends}, ${misc:Depends}, avahi-daemon
diff -Nrup a/debian/pulseaudio-module-consolekit.install b/debian/pulseaudio-module-consolekit.install
--- a/debian/pulseaudio-module-consolekit.install	1970-01-01 00:00:00.000000000 +0000
+++ b/debian/pulseaudio-module-consolekit.install	2017-07-08 12:04:37.436752291 +0000
@@ -0,0 +1 @@
+usr/lib/pulse-*/modules/module-console-kit.so
diff -Nrup a/debian/pulseaudio.install b/debian/pulseaudio.install
--- a/debian/pulseaudio.install	2017-06-15 10:07:30.000000000 +0000
+++ b/debian/pulseaudio.install	2017-07-08 12:04:20.916752354 +0000
@@ -20,7 +20,6 @@ usr/lib/pulse-*/modules/librtp.so
 [linux-any] usr/lib/pulse-*/modules/module-alsa-sink.so
 [linux-any] usr/lib/pulse-*/modules/module-alsa-source.so
 usr/lib/pulse-*/modules/module-always-sink.so
-usr/lib/pulse-*/modules/module-console-kit.so
 usr/lib/pulse-*/modules/module-device-restore.so
 usr/lib/pulse-*/modules/module-echo-cancel.so
 usr/lib/pulse-*/modules/module-stream-restore.so

Attachment: signature.asc
Description: PGP signature

Reply via email to