On Fri, Jul 07, 2017 at 10:10:04PM +0200, Tomasz Buchert wrote: > Wow, this is nice. Would you mind adding some tests to cover this? > Ideally, we would have coverage for all rsyncable "dialects" we > support. Can you commit to collab-maint?
Something like this perhaps: diff --git a/test/test_roundtrip.sh b/test/test_roundtrip.sh index 5465ed4..b82620d 100644 --- a/test/test_roundtrip.sh +++ b/test/test_roundtrip.sh @@ -19,6 +19,18 @@ test_bz2() { assertWorksWithTarball $SAMPLES/tarballs/foo-1.0.tar.bz2 } +test_gz_135_rsyncable() { + assertWorksWithTarball $SAMPLES/tarballs/libinotify-kqueue-1.3.5rsyncable_20120419.orig.tar.gz +} + +test_gz_14_rsyncable() { + assertWorksWithTarball $SAMPLES/tarballs/libinotify-kqueue-1.4rsyncable_20120419.orig.tar.gz +} + +test_gz_16_rsyncable() { + assertWorksWithTarball $SAMPLES/tarballs/libinotify-kqueue-1.6rsyncable_20120419.orig.tar.gz +} + test_gz() { assertWorksWithTarball $SAMPLES/tarballs/foo-1.0.tar.gz } I tried with a smaller tar file first, but you need to be at least 4 or 8KB depending on gzip version to trigger the rsyncable window size thing so I used the other sample which resulted in different files for each gzip version. -- Len Sorensen
libinotify-kqueue-1.3.5rsyncable_20120419.orig.tar.gz
Description: application/gzip
libinotify-kqueue-1.4rsyncable_20120419.orig.tar.gz
Description: application/gzip
libinotify-kqueue-1.6rsyncable_20120419.orig.tar.gz
Description: application/gzip