On 07/12/2017 08:00 AM, Marc Dequènes (duck) wrote: > --- imapproxy.service.orig 2017-07-12 14:57:35.000000000 +0200 > +++ /lib/systemd/system/imapproxy.service 2017-07-12 > 14:50:15.000000000 +0200 > @@ -8,3 +8,8 @@ > Type=forking > ExecStartPre=/usr/share/imapproxy/prepare-chroot > ExecStart=/usr/sbin/imapproxyd -f /etc/imapproxy.conf > +PIDFile=/run/imapproxy.pid > + > +[Install] > +WantedBy=multi-user.target > +
imapproxyd actually writes the PID file to /var/run/imapproxy.pid (by default). With /var/run being a symlink to /run, these should be equivalent. It seems slightly more correct to me to use: PIDFile=/var/run/imapproxy.pid Does it still work for you with /var/run instead of /run? I'm not sure on the normal etiquette for crediting in debian/changelog. I'd like to credit you for the patch. The obvious way to do so is to mark you as the git author, but then I'm writing a commit message that has your name attached, which feels weird. So I can either do that, so this happens in debian/changelog: [ Marc Dequènes ] * Correct the service file (Closes: 868150) Or I can let the git author default to me and just credit you textually in the commit message. Do you have a preference? Are you okay with "Correct the service file" or would you like to provide your own commit message for that patch? -- Richard
