Package: ocfs2-tools Severity: minor Tags: patch Hi,
Your debconf templates do not follow the developers reference and some strings should not be marked as translatable: > Template: ocfs2-tools/clustername > Type: string > -_Default: ocfs2 > -_Description: Enter the name of the cluster to start at boot time: > +Default: ocfs2 > +_Description: Name of the cluster to start at boot time: This default field should not be marked as translatable. Do not use pointless "Enter", "Please choose", etc. > Template: ocfs2-tools/heartbeat_threshold > Type: string > -_Default: 7 > +Default: 7 Should not be marked as translatable. > -_Description: Please enter the desired O2CB heartbeat threshold. Its default > value is 7 (12 seconds). > +_Description: O2CB heartbeat threshold: This is the short description, it should be kept short. For a string, the short description is a prompt. > - The O2CB heartbeat threshold sets up the maximum time in seconds that a > node awaits > - for an I/O operation. After it, the node "fences" itself, and you will > probably see a crash. > + The O2CB heartbeat threshold sets up the maximum time in seconds that a > + node awaits for an I/O operation. After it, the node "fences" itself, > + and you will probably see a crash. Limit your lines to around 72 chars, it is more readable. > - Raise it if you have slow disks and/or crashes with kernel messages like: > + Its default value is 7 (12 seconds). > . > - o2hb_write_timeout: 164 ERROR: heartbeat write timeout to device XXXX after > NNNN miliseconds > + Raise it if you have slow disks and/or crashes with kernel messages > + like: > . > + o2hb_write_timeout: 164 ERROR: heartbeat write timeout to device XXXX > + after NNNN miliseconds Add the default value in the long description and limit your lines to around 72 chars. In the two first templates, it may lack of a long description. I don't know what you assume the user already knows. Cheers, -- Thomas Huriaux
--- ocfs2-tools.templates.orig 2006-02-12 14:06:36.000000000 +0100 +++ ocfs2-tools.templates 2006-02-12 14:09:11.000000000 +0100 @@ -5,19 +5,23 @@ Template: ocfs2-tools/clustername Type: string -_Default: ocfs2 -_Description: Enter the name of the cluster to start at boot time: +Default: ocfs2 +_Description: Name of the cluster to start at boot time: Template: ocfs2-tools/heartbeat_threshold Type: string -_Default: 7 -_Description: Please enter the desired O2CB heartbeat threshold. Its default value is 7 (12 seconds). - The O2CB heartbeat threshold sets up the maximum time in seconds that a node awaits - for an I/O operation. After it, the node "fences" itself, and you will probably see a crash. +Default: 7 +_Description: O2CB heartbeat threshold: + The O2CB heartbeat threshold sets up the maximum time in seconds that a + node awaits for an I/O operation. After it, the node "fences" itself, + and you will probably see a crash. . It is calculated as the result of: (threshold - 1) x 2. . - Raise it if you have slow disks and/or crashes with kernel messages like: + Its default value is 7 (12 seconds). . - o2hb_write_timeout: 164 ERROR: heartbeat write timeout to device XXXX after NNNN miliseconds + Raise it if you have slow disks and/or crashes with kernel messages + like: . + o2hb_write_timeout: 164 ERROR: heartbeat write timeout to device XXXX + after NNNN miliseconds
signature.asc
Description: Digital signature
