tags 352159 + patch
quit

On Sun, Feb 12, 2006 at 10:09:13PM +0530, Joshua N Pritikin wrote:
> See bcron-exec.c:
> 
>   if (0 && initgroups(pw->pw_name, pw->pw_gid) != 0)
>     die1sys(111, "Could not initgroups");
> 
> That can't be correct.

Yes, I think so too, and'll take this upstream.

Thanks for the report, Gerrit.
Index: bcron-exec.c
===================================================================
RCS file: /cvs/bcron/bcron-exec.c,v
retrieving revision 1.1.1.1
diff -u -r1.1.1.1 bcron-exec.c
--- bcron-exec.c        1 Apr 2005 17:24:37 -0000       1.1.1.1
+++ bcron-exec.c        14 Feb 2006 14:41:34 -0000
@@ -111,7 +111,7 @@
   dup2(fdout, 1);
   dup2(fdout, 2);
   close(fdout);
-  if (0 && initgroups(pw->pw_name, pw->pw_gid) != 0)
+  if (initgroups(pw->pw_name, pw->pw_gid) != 0)
     die1sys(111, "Could not initgroups");
   if (setgid(pw->pw_gid) != 0)
     die1sys(111, "Could not setgid");

Reply via email to