On Mon, Aug 21, 2017 at 11:38 PM, Julien Puydt <julien.pu...@laposte.net> wrote: > Hi, > > Le 21/08/2017 à 22:44, roucaries bastien a écrit : >> On Mon, Aug 21, 2017 at 10:33 PM, roucaries bastien >> <roucaries.bastien+deb...@gmail.com> wrote: >>> control: owner -1 ro...@debian.org >>> >>> Will sponsor this one. Will review >>> >>> On Sun, Aug 20, 2017 at 9:59 PM, Andrey Rahmatullin <w...@debian.org> wrote: >>>> Control: retitle -1 RFS: node-regjsparser/0.2.1-1 [ITP] >> >> * uscan is now 4 > > Done. > >> *demo should be supplied as example > > I don't know how that demo is to be run, so I find it annoying to ship > it as an example :-/ > > Notice that the manpage I wrote has examples. > >> * test/*.json should be remove FTBFS (if you could regenerate you are >> welcome to do) > > Same question as for nodejsgen : if it isn't used, do we still consider > it FTBFS? Yes repack is safer and bonus point package is smaller
> >> * parser.js FTBFS search generated in source > > Darn. I had checked that we had the tool to generate it in node-esprima, > but now I see it requires node-unicode-8.0.0, which we don't have :-( > >> * a smoketest will be welcome (readme.md seems to include something) > > I added one. > > The problem with parser.js is definitively a show stopper : that means > I'll have to tackle the node-unicode-* packages issue sooner than I > expected :-/ > > Snark on #debian-js