Package: moc
Version: 1:2.6.0~svn-r2788-1
Severity: normal
Tags: patch

MOC exits with a fatal error when any of the following conditions is met:
- Any command is bound to Ctrl-p in a custom keymap.
- The toggle_percent command is bound to any key.
This doesn't happen when other default key bindings are modified.

The cause of this seems to be a mistake in 04_playtime_perc.patch:
> From: Elimar Riesebieter <[email protected]>
> Subject: Assign "Switch on/off play time percentage"
>
> Index: moc-2.6~alpha1+r2758/keys.c
> ===================================================================
> --- moc-2.6~alpha1+r2758.orig/keys.c
> +++ moc-2.6~alpha1+r2758/keys.c
> @@ -204,7 +204,7 @@ static struct command commands[] = {
>               "toggle_percent",
>               "Switch on/off play time percentage",
>               CON_MENU,
> -             { -1 },
> +             {CTRL('p'), -1 },
>               0
>       },
>       {

The patch adds a new binding to the keys field, but doesn't update the
default_keys field. The default_keys field is supposed to contain the number of
default bindings.

The patch should look something like this instead:
> --- keys.c.orig
> +++ keys.c
> @@ -204,8 +204,8 @@
>               "toggle_percent",
>               "Switch on/off play time percentage",
>               CON_MENU,
> -             { -1 },
> -             0
> +             { CTRL('p'), -1 },
> +             1
>       },
>       {
>               KEY_CMD_PLIST_ADD_FILE,

-- System Information:
Debian Release: stretch/sid
  APT prefers xenial-updates
  APT policy: (500, 'xenial-updates'), (500, 'xenial-security'), (500, 
'xenial'), (100, 'xenial-backports')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.4.0-92-generic (SMP w/4 CPU cores)
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages moc depends on:
ii  libasound2                        1.1.0-0ubuntu1
ii  libc6                             2.23-0ubuntu9
ii  libcurl3-gnutls                   7.47.0-1ubuntu2.2
ii  libdb5.3                          5.3.28-11
ii  libfaad2                          2.8.0~cvs20150510-1
ii  libflac8                          1.3.1-4
ii  libgcc1                           1:6.0.1-0ubuntu1
ii  libid3tag0                        0.15.1b-11
ii  libjack-jackd2-0 [libjack-0.116]  1.9.10+20150825git1ed50c92~dfsg-1ubuntu1
ii  libltdl7                          2.4.6-0.1
ii  libmad0                           0.15.1b-8ubuntu1
ii  libmagic1                         1:5.25-2ubuntu1
ii  libmodplug1                       1:0.8.8.5-2
ii  libmpcdec6                        2:0.1~r459-4.1build1
ii  libncursesw5                      6.0+20160213-1ubuntu1
ii  libogg0                           1.3.2-1
ii  libopusfile0                      0.7-1
ii  libpopt0                          1.16-10
ii  librcc0                           0.2.12-0.1
ii  libresid-builder0c2a              2.1.1-14ubuntu2
ii  libsamplerate0                    0.1.8-8
ii  libsidplay2v5                     2.1.1-14ubuntu2
ii  libsidutils0                      2.1.1-14ubuntu2
ii  libsndfile1                       1.0.25-10ubuntu0.16.04.1
ii  libspeex1                         1.2~rc1.2-1ubuntu1
ii  libstdc++6                        5.4.0-6ubuntu1~16.04.4
ii  libtagc0                          1.9.1-2.4ubuntu1
ii  libtinfo5                         6.0+20160213-1ubuntu1
ii  libvorbisfile3                    1.3.5-3
ii  libwavpack1                       4.75.2-2

moc recommends no packages.

Versions of packages moc suggests:
pn  moc-ffmpeg-plugin  <none>

-- no debconf information

Reply via email to