Hi,
> Apart from bug #874481, I found some more problems. The new version
> seems to read the environment $http_proxy and use it even if the
> connection is set up to use no proxy.
>
> That is suboptimal for many reasons. First the http_proxy does not
> define a socks proxy. Second it leads to strange problems that it tries
> to connect the http_proxy from a potential remote system (In my case I
> started using tsocks to mitigate bug #874481 and found some strange
> connection tries on the remote system to the proxy in $http_proxy).
>
> Unsetting that environments before starting psi does help (and the
> connection via tsocks work).
As far as I see this problem is not directly in Psi+:
boradmin@Tehnick:~/Hobby/Devel/Psi+/repositories/psi-plus-snapshots$ grep -ri
http_proxy | wc -l
0
boradmin@Tehnick:~/Hobby/Devel/Psi+/repositories/psi-plus-snapshots$ grep -ri
https_proxy | wc -l
0
But in QtBase:
boradmin@Tehnick:~/Hobby/Devel/Qt-opensource/qtbase$ git checkout v5.9.1
HEAD is now at 160533328c... Remove mention of reverted fix
boradmin@Tehnick:~/Hobby/Devel/Qt-opensource/qtbase$ grep -r http_proxy
src/network/kernel/qnetworkproxy.cpp: the "http_proxy" environment variable.
This variable must be a URL
src/network/kernel/qnetworkproxy_generic.cpp: * Construct a proxy from the
environment variables http_proxy and no_proxy.
src/network/kernel/qnetworkproxy_generic.cpp: proxy_env =
qgetenv("http_proxy");
src/network/kernel/qnetworkproxy_generic.cpp: // Fallback to http_proxy is
no protocol specific proxy was found
src/network/kernel/qnetworkproxy_generic.cpp: proxy_env =
qgetenv("http_proxy");
tests/auto/network/kernel/qnetworkproxyfactory/tst_qnetworkproxyfactory.cpp:
QTest::newRow("no proxy") << QByteArray("http_proxy") << QByteArray() <<
QNetworkProxy::NoProxy
tests/auto/network/kernel/qnetworkproxyfactory/tst_qnetworkproxyfactory.cpp:
QTest::newRow("socks5") << QByteArray("http_proxy") <<
QByteArray("socks5://127.0.0.1:4242")
tests/auto/network/kernel/qnetworkproxyfactory/tst_qnetworkproxyfactory.cpp:
QTest::newRow("http") << QByteArray("http_proxy") <<
QByteArray("http://example.com:666";)
boradmin@Tehnick:~/Hobby/Devel/Qt-opensource/qtbase$ grep -r https_proxy
src/network/kernel/qnetworkproxy_generic.cpp: proxy_env =
qgetenv("https_proxy");
More dipper investigation is required.
Best regards,
Boris
