Source: qemu
Version: 1:2.8+dfsg-7
Severity: wishlist
Tags: patch
User: reproducible-bui...@lists.alioth.debian.org
Usertags: randomness
X-Debbugs-Cc: reproducible-b...@lists.alioth.debian.org

While working on the Reproducible Builds effort [0], we noticed that
qemu's documentation and manpages generates non-reproducible output,
possibly based on which shell is set to /bin/sh and the handling of
whitespace in the corresponding echo implementation[1].

I believe the attached patch should resolve this issue by removing
trailing whitespace from two lines in the file used to generate the
documentation, though I haven't confirmed for sure.

 [0] https://reproducible-builds.org/
 [1] 
https://tests.reproducible-builds.org/debian/rb-pkg/buster/amd64/diffoscope-results/qemu.html

live well,
  vagrant

From 96d609767abeaec17d9f4e25a6a454269ade12e9 Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagr...@debian.org>
Date: Wed, 13 Sep 2017 12:48:29 -0700
Subject: [PATCH] Remove trailing whitespace in qemu-options documentation, as
 it causes reproducibility issues depending on the echo implementation used by
 the Makefile.

---
 qemu-options.hx | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/qemu-options.hx b/qemu-options.hx
index c534a2f7f9..baeb5c5bb7 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -190,8 +190,8 @@ Set default value of @var{driver}'s property @var{prop} to @var{value}, e.g.:
 qemu-system-i386 -global ide-drive.physical_block_size=4096 -drive file=file,if=ide,index=0,media=disk
 @end example
 
-In particular, you can use this to set driver properties for devices which are 
-created automatically by the machine model. To create a device which is not 
+In particular, you can use this to set driver properties for devices which are
+created automatically by the machine model. To create a device which is not
 created automatically and set properties on it, use -@option{device}.
 
 -global @var{driver}.@var{prop}=@var{value} is shorthand for -global
-- 
2.11.0

Attachment: signature.asc
Description: PGP signature

Reply via email to