I could fix the bug and pushed to svn my modifications. Everything seems to build with java 8 AND java 9
I do not really understand the reason, but it works.... However "binary" does not work: # java -jar rdp_classifier.jar no main manifest attribute, in rdp_classifier.jar the main-class seems not to be set, but it is the same for Java 8, so something may still be missing? Olivier On 09/15/2017 03:30 PM, Olivier Sallou wrote: > I had a quick look. > > I made some modifications for Java 9 , but the tests do not match usual > Java 9 migration issues and tests do not show any special problem, only > NullPointerException > > <error > type="java.lang.NullPointerException">java.lang.NullPointerException > at java.base/java.io.Reader.<init>(Reader.java:78) > at > java.base/java.io.InputStreamReader.<init>(InputStreamReader.java:72) > at > edu.msu.cme.rdp.classifier.rrnaclassifier.TrainingInfoTest.testCreateGenusWordProbList(Unknown > Source) > at > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native > Method) > at > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > > I have no idea why, but this is not a simple Java9 migration. > > So I have not pushed my updates yet as this is not the current problem. > > > On 09/15/2017 02:36 PM, Andreas Tille wrote: >> Hi Olivier, >> >> thanks for those hints that sound good. Would you mind adding this as >> patches to VCS? >> >> Kind regards >> >> Andreas. >> >> On Fri, Sep 15, 2017 at 02:21:59PM +0200, Olivier Sallou wrote: >>> On 09/15/2017 01:24 PM, Andreas Tille wrote: >>>> control: tags -1 help >>>> >>>> Sorry, I have no idea how to fix this. :-( >>>> Any hint is welcome. >>> you need to add to compil the option "--add-modules java.se.ee". The pb >>> is it works for Java 9 but not for Java 8. >>> To match both, you can do something like: >>> >>> <if><equals arg1="${ant.java.version}" arg2="1.8" /> >>> <then> >>> <javac ....></javac> >>> </then> >>> <else> >>> <javac ....><compilerarg line="--add-modules >>> java.se.ee"/></javac> >>> </else> >>> </if> >>> >>> >>> In build.xml >>> >>> Else, an option is to build for Java 1.8 specifically specifying >>> >>> <javac ... source="1.8" target="1.8"> >>> </javac> >>> >>> Compilation should work this way. At runtime (execution) with Java9, >>> user has to add "--add-modules java.se.ee" to the java command-line. >>> The problem, again, is that if user is using java8, this command is not >>> recognized. >>> >>> >>>> Kind regards >>>> >>>> Andreas. >>>> >>> -- >>> Olivier Sallou >>> IRISA / University of Rennes 1 >>> Campus de Beaulieu, 35000 RENNES - FRANCE >>> Tel: 02.99.84.71.95 >>> >>> gpg key id: 4096R/326D8438 (keyring.debian.org) >>> Key fingerprint = 5FB4 6F83 D3B9 5204 6335 D26D 78DC 68DB 326D 8438 >>> >>> >>> -- Olivier Sallou IRISA / University of Rennes 1 Campus de Beaulieu, 35000 RENNES - FRANCE Tel: 02.99.84.71.95 gpg key id: 4096R/326D8438 (keyring.debian.org) Key fingerprint = 5FB4 6F83 D3B9 5204 6335 D26D 78DC 68DB 326D 8438