Package: u-boot-exynos
Version: 2017.09+dfsg1-1
Severity: normal
Tags: patch

The odroid-xu3 platform passes a wrong "console" argument on the kernel 
commandline:

console=console=ttySAC2,115200n8

>From the source, it's clear where this comes from:
include/configs/odroid_xu3.h:
#define CONFIG_DEFAULT_CONSOLE         "console=ttySAC2,115200n8\0"
#define CONFIG_EXTRA_ENV_SETTINGS \
[...]
        "console=" CONFIG_DEFAULT_CONSOLE \

/etc/flash-kernel/bootscript/bootscr.uboot-generic:
  setenv bootargs "${bootargs} console=${console}"

The patch below makes the situation equal to what Debian patches in odroid.h: 
drop it from CONFIG_DEFAULT_CONSOLE. Judging from a grep in include/configs, I 
think the same situation exists for s5pc210_universal.h, s5p_goni.h, trats2.h 
and trats.h, but I don't have these devices. There are many more header files 
that have a "console=" in their CONFIG_DEFAULT_CONSOLE, but I don't see that 
definition being subsequently used somewhere, so I don't know whether it's 
being used wrongly or not.

Thanks for your efforts,

Peter.

*** 
src/debian/u-boot-2017.09+dfsg1/debian/patches/odroid-xu3/double-console-string
Index: u-boot-2017.09+dfsg1/include/configs/odroid_xu3.h
===================================================================
--- u-boot-2017.09+dfsg1.orig/include/configs/odroid_xu3.h
+++ u-boot-2017.09+dfsg1/include/configs/odroid_xu3.h
@@ -34,7 +34,7 @@
 
 #define CONFIG_SYS_INIT_SP_ADDR        (CONFIG_SYS_LOAD_ADDR - 0x1000000)
 
-#define CONFIG_DEFAULT_CONSOLE         "console=ttySAC2,115200n8\0"
+#define CONFIG_DEFAULT_CONSOLE         "ttySAC2,115200n8\0"
 
 /* USB */
 #define CONFIG_USB_EHCI_EXYNOS


-- System Information:
Debian Release: 9.1
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable'), (1, 'experimental')
Architecture: armhf (armv7l)

Kernel: Linux 4.9.0-3-armmp-lpae (SMP w/8 CPU cores)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_GB:en (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

-- no debconf information

Reply via email to