----- Forwarded message from [EMAIL PROTECTED] -----

Date: Sat, 18 Feb 2006 16:34:48 +0100
From: [EMAIL PROTECTED]
To: Christian Perrier <[EMAIL PROTECTED]>
Subject: Re: Bug#348421: samba: please remove broken vfs module: extd_audit

On Tuesday 17 January, 2006 � 06:58:20AM +0100, Christian Perrier wrote:
> Quoting juan ([EMAIL PROTECTED]):
> > Package: samba
> > Version: 3.0.21a-1
> > Severity: normal
> > 
> > looking at the source code, it's clear the the parameters announced in
> > the samba doc are pure fiction. (log level = 0 vfs:x).
> > please remove extd_audit until it's fixed upstream, it's just dangerous
> > for a production server and confusing for the users.
> 
> Do you have more information for us to provide to upstream?

i can take an example :

vfs_extd_audit.c:151

151 static SMB_STRUCT_DIR *audit_opendir(vfs_handle_struct *handle, 
connection_struct *conn, const char *fname, const char *mask, uint32 a        
ttr)
152 {
153     SMB_STRUCT_DIR *result;
154 
155     result = SMB_VFS_NEXT_OPENDIR(handle, conn, fname, mask, attr);
156 
157     syslog(audit_syslog_priority(handle), "opendir %s %s%s\n",
158            fname,
159            (result == NULL) ? "failed: " : "",
160            (result == NULL) ? strerror(errno) : "");
161     DEBUG(1, ("vfs_extd_audit: opendir %s %s %s\n",
162            fname,
163            (result == NULL) ? "failed: " : "",
164            (result == NULL) ? strerror(errno) : ""));
165 
166     return result;


The documentation say that you can controll verbosity
http://us3.samba.org/samba/docs/man/Samba-HOWTO-Collection/VFS.html#id2617000

with log level = 0 vfs:0
: Make Directory, Remove Directory, Unlink

it's clear that in audit_opendir(), the call is logged to syslog all the time.

----- End forwarded message -----

-- 



Reply via email to