Source: radare2 Version: 2.0.0+dfsg-1 Severity: important Tags: upstream Justification: fails to build from source (but built successfully in the past) User: [email protected]
The latest build of radare2 for hurd-i386 (admittedly not a release architecture) failed: error: 'PATH_MAX' undeclared (first use in this function); did you mean 'NAME_MAX'? The Hurd famously has no fixed PATH_MAX. Best practice is to refrain from blindly preallocating buffers, which in general leads to either wasted space or truncation (or worse, overflows). However, if avoiding such preallocation is infeasible, you can either determine the official limit at runtime by looking up _PC_PATH_MAX via pathconf or supply your own fallback constant definition (typically 4096). Could you please take a look? Thanks! -- Aaron M. Ucko, KB1CJC (amu at alum.mit.edu, ucko at debian.org) http://www.mit.edu/~amu/ | http://stuff.mit.edu/cgi/finger/[email protected]
