On 2017-10-23 16:52:01, Mattia Rizzolo wrote:
> Hi!
>
> On Mon, Oct 23, 2017 at 10:33:58AM -0400, Antoine Beaupré wrote:
>> I figured I would do *some* refactoring while I was there to avoid
>> further code duplication.
>
> YES! Please refactor it all :D
>
>> I haven't tested all scenarios (and the test suite is limited inthat
>> regard) but this mostly works in my tests locally.
>
> I'd be very happy if you could expand the testsuite some more: that's
> one reason why refactoring that thing is so unappealing, breakages are
> very easy to miss. I'd actually take that patch before the others.
>
>
> (I haven't reviewed the patches just yet, but from a quick look they
> seem sane at least)
There was at least this bit missing to get the first changelog right...
--
A patriot must always be ready to defend his country
against his government.
- Edward Abbey
>From 4cad5da523ce6fca51ceb5f5cd2b19286b738c22 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Antoine=20Beaupr=C3=A9?= <anar...@debian.org>
Date: Mon, 23 Oct 2017 17:01:47 -0400
Subject: [PATCH 3/3] add missing changelog line template for --lts
---
scripts/debchange.pl | 3 +++
1 file changed, 3 insertions(+)
diff --git a/scripts/debchange.pl b/scripts/debchange.pl
index d01ca9a8..27915460 100755
--- a/scripts/debchange.pl
+++ b/scripts/debchange.pl
@@ -1273,6 +1273,9 @@ ()
print O " * Non-maintainer upload by the Security Team.\n";
}
$line = 1;
+ } elsif ($opt_lts && ! $opt_news) {
+ print O " * Non-maintainer upload by the LTS Security Team.\n";
+ $line = 1;
} elsif ($opt_team && ! $opt_news) {
print O " * Team upload.\n";
$line = 1;
--
2.11.0
