On 2017年10月30日 22:15, Aaron M. Ucko wrote: > Control: user debian-m...@lists.debian.org > Control: usertag 880149 mips > > "Aaron M. Ucko" <u...@debian.org> writes: > >> On s390x, it did better, but a third of the tests still failed, >> quite possibly for related reasons: > > The same three tests (test_arr, test_encr_decr, and test_key) also > failed on mips and the non-release architecture hppa, which hadn't yet > attempted to build libntru when I originally reported this bug. All of > the architectures to encounter test suite errors to date are big-endian, > but so are powerpc and ppc64, which ran into no such trouble. Is > upstream perhaps treating all non-PowerPC architectures as little-endian? >
Hi Aaron,
Thanks for reporting the bug.
Yes. Seems so. It seems to me that there are bugs on the upstream. I'll
contact the upstream and fix that issue.
It is inside src/ntru_endian.h
#ifdef __GLIBC__
#if __GLIBC__ <= 2 || ( __GLIBC__ == 2 && __GLIBC_MINOR__ < 9 )
#ifndef __powerpc__
/* assume little endian */
#define htole64(x) (x)
#define htole32(x) (x)
#define htole16(x) (x)
#endif
#endif
#endif
The __GLIBC__ should be <= 1 or < 2. Which makes more sense.
GLIBC version less than 2.9 we define that. Otherwise we handle these
functions to endian.h
I'll forward a bug report to the upstream soon.
Yours,
Paul
--
PaulLiu (劉穎駿)
E-mail: Ying-Chun Liu (PaulLiu) <paul...@debian.org>
signature.asc
Description: OpenPGP digital signature
