Bug#880427: tinyproxy: If tinyproxy receives a SIGHUP, then the children exit without being restarted and tinyproxy hangs.

[Stephan Leemburg]

Package: tinyproxy
Version: 1.8.4-2
Severity: grave
Tags: patch
Justification: renders package unusable

Dear Maintainer,

   * What led up to the situation?
   
   Hanging tinyproxy, no proxied connections are handled anymore.

   * What exactly did you do (or not do) that was effective (or
     ineffective)?

   Logrotate sends a SIGHUP, which triggers this problem.

   * What was the outcome of this action?

   Unusable tinyproxy.

   * What outcome did you expect instead?

   Usable tinyproxy


   Please see patch below

-- System Information:
Debian Release: 9.2
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 4.4.19-1-pve (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=ANSI_X3.4-1968) 
(ignored: LC_ALL set to C), LANGUAGE=en_US.UTF-8 (charmap=ANSI_X3.4-1968) 
(ignored: LC_ALL set to C)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages tinyproxy depends on:
ii  init-system-helpers  1.48
ii  libc6                2.24-11+deb9u1
ii  logrotate            3.11.0-0.1
ii  lsb-base             9.20161125

tinyproxy recommends no packages.

tinyproxy suggests no packages.
-- no debconf information

########### PATCH BELOW

--- tinyproxy-1.8.4/src/child.c 2015-12-07 15:19:00.000000000 +0100
+++ tinyproxy/src/child.c       2017-10-31 13:38:48.542095431 +0100
@@ -233,6 +233,9 @@
 
                 ret = select(maxfd + 1, &rfds, NULL, NULL, NULL);
                 if (ret == -1) {
+                        if (errno == EINTR) {
+                                continue;
+                        }
                         log_message (LOG_ERR, "error calling select: %s",
                                      strerror(errno));
                         exit(1);