Package: tp-smapi-dkms
Version: 0.42-1
Severity: normal
Dear Maintainer,
After installing, the package, I was able to manually run modprobe
tp_smapi and verify that it works. After rebooting, the module was
not loaded. I believe hardware drivers are loaded automatically when
there is an attempt to access the device. So AFAIK this should be the
case for tp_smapi. I noticed gkrellm-thinkbat failed after the
reboot. So I ran "journalctl -b" which shows:
.. sysfsutils[805]: Setting sysfs variables...unknown attribute
devices/platform/smapi/BAT0/start_charge_thresh ... fail
.. sysfsutils[805]: unknown attribute
devices/platform/smapi/BAT0/stop_charge_thresh ... failed!
If this is not a module that should load on demand, then the installer
should probably be configuring the system to load it unconditionally.
Or failing that, the documentation is lacking and needs to cover this.
I'm noticing many ways to load a module:
1) Add it to /etc/modules
2) Add it to /etc/modprobe.d/dkms.conf
3) echo 'tp-smapi' > /etc/modules-load.d/tp-smapi.conf
4) create a file in /etc/init.d that includes "modprobe tp_smapi"
5) create /etc/systemd/system/tp_smapi_set_battery_thresholds.service:
[Unit]
Description=Set Battery Charge Thresholds by tp_smapi
[Service]
Type=oneshot
ExecStart=/usr/sbin/set_battery_thresholds
RemainAfterExit=yes
[Install]
WantedBy=multi-user.target
Which way is the standard practice on Debian? I suspect the
tp_smapi_set_battery_thresholds.service file above should be part of
the package. Or is dkms going to be more accepted in the future?
There's also a possible documentation clash with sysfsutil.
(1) Sysfsutil suggests (by example) including these lines in
/etc/sysfs.conf:
devices/platform/smapi/BAT0/start_charge_thresh=40
devices/platform/smapi/BAT0/stop_charge_thresh=85
(2) However, that seems redundant with these instructions in README:
# echo 40 > /sys/devices/platform/smapi/BAT0/start_charge_thresh
# echo 70 > /sys/devices/platform/smapi/BAT0/stop_charge_thresh
Approach (1) seems the most sensible - most users will want these
settings to persist, and I'm guessing approach (2) is temporary. But
the README only mentions approach (2). IMO the README should be
updated to show either both approaches or just approach (1). It
already references http://thinkwiki.org/wiki/tp_smapi, so users going
further with experimentation can learn about approach (2) there.
-- System Information:
Debian Release: 9.2
APT prefers stable-updates
APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 4.9.0-4-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=1510159819
UTF-8), LANGUAGE=en_US.UTF-8 (charmap=1510159819
UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
Versions of packages tp-smapi-dkms depends on:
ii dkms 2.3-2
tp-smapi-dkms recommends no packages.
tp-smapi-dkms suggests no packages.
