Source: stenc
Version: 1.0.7-1
Severity: important
Tags: upstream
Justification: fails to build from source
User: debian-h...@lists.debian.org
Usertags: hurd-i386

Builds of stenc for hurd-i386 and kfreebsd-* (admittedly not release
architectures) have been failing:

  main.cpp: In function 'int main(int, char**)':
  main.cpp:72:5: error: 'memset' was not declared in this scope
  main.cpp:76:5: error: 'memcpy' was not declared in this scope
  main.cpp:107:13: error: 'strncmp' was not declared in this scope

These declarations are absent because upstream for some reason decided
to conditionalize the inclusion of <string.h> (and <stdlib.h>, for
that matter) on OS_LINUX.  These are bog-standard headers that should
be safe to #include unconditionally.  However, if the upstream
developers really want to be paranoid, they can capitalize on the
build system's existing checks and conditionalize on HAVE_STRING_H
and/or HAVE_STDLIB_H as desired.

Could you please take a look?

Thanks!

-- 
Aaron M. Ucko, KB1CJC (amu at alum.mit.edu, ucko at debian.org)
http://www.mit.edu/~amu/ | http://stuff.mit.edu/cgi/finger/?a...@monk.mit.edu

Reply via email to