On Fri, Oct 27, 2017 at 4:23 AM, Daniel Kahn Gillmor wrote: > On Thu 2017-08-31 12:07:10 +1000, Jeremy Visser wrote: >> I've attached a patch which fixes the issue.
Thanks for the patch, and for forwarding it here (don't know where it was sent). > > Jeremy's patch (below) looks reasonable to me. Even better would be to > have it include other useful metadata in the [Unit] section, like: > > Documentation=man:xscreensaver(1) > Documentation=man:xscreensaver-command(1) > Documentation=man:xscreensaver-demo(1) > PartOf=graphical-session.target > Thanks. > xscreensaver(1) currently has a suggestion for this file. It should > probably also be adjusted to remove the example, and explain > specifically that all the user needs to do is: > > systemctl --user enable xscreensaver > > Arguably, this user unit should be enabled by default. Is there any > reason to ship it disabled? I am not so into systemd "units", but possibly relevant to your question is that it is fully possible that the xscreensaver package is installed on a system, but that individual users don't want to have it running. Whether it should start by default for a user depends on the desktop environment. Regards, Tormod > > --dkg > >> From 76072fa4cba00e6a6009324d6b9e0cf1d3fdc82f Mon Sep 17 00:00:00 2001 >> From: Jeremy Visser <jeremyvis...@google.com> >> Date: Thu, 31 Aug 2017 11:53:00 +1000 >> Subject: [PATCH] Fix broken systemd unit >> >> The ExecStart= line must be an absolute path as per systemd.service(5), >> but is currently a relative path. This change points it to >> /usr/bin/xscreensaver. >> ---
