Control: reopen -1
On Mon, Dec 25, 2017 at 08:12:15PM +0000, Andreas Rönnquist wrote:
> Add patch trap_errors_from_make.patch (Closes: #883526)
Thank you for attempting to fix this. Unfortunately, this doesn't quite
do it. My initial suggestion to add set -e apparently doesn't do it.
Essentially what's there is roughly similar to
( echo 1; false; echo 2 ) || echo 3
and you changed it to
( set -e; echo 1; false; echo 2 ) || echo 3
according to my wrong suggestion. Unfortunately, this prints 1 and 2,
but not 3 and gives a successful return. This is unintuitive to me and
is explained at
https://unix.stackexchange.com/questions/296526/set-e-in-a-subshell. I'm
sorry for not having seen this initially. In any case, it doesn't
propagate the failure now.
Furthermore, there are other instances of this issue. One is with
invoking GLIB_GENMARSHAL from src/Makefile.am. But src/doc/Makefile.am
and src/icons/Makefile.am suffer from the same issues.
Helmut
