On Tue, Jan 02, 2018 at 10:58:13AM -0800, Jonathan Nieder wrote: > > > The option is called commit.gpgsign not commit.pgpsign (according to > > "man git-config")…
Right, sorry for mistyping this.
> > …and it doesn't affect git-commit-tree, that's why "gbp import-orig" is
> > unaffected
>
> This behavior is intentional. Often convenience features like this
> one are provided in user-facing commands (like "git commit") and not
> scripting commands (like "git commit-tree"). Part of that is because
> it is easier to understand the intent behind a user calling a
> user-facing command. When a script calls a command like commit-tree,
> we don't have information about the higher-level operation that this
> was a component of, so we err on the side of predictability.
ACK, that makes sense.
> Could "gbp import-orig" gain a --sign-commits option to allow a user
> to explicitly indicate whether they want to pass --gpg-sign to
> commit-tree? That way, the user intent is clearer. Making it default
> to true when commit.gpgsign would make sense in that context.
I'm happy to tweak my own configuration, to add or change something in
either ~/.gitconfig or ~/.gbp.conf.
> Despite how it may seem from the above comments, I am not completely
> sure about whether "git commit-tree" should default to --gpg-sign when
> commit.gpgsign is set.
Also, isn't commit-tree configurable at all? git-commit-tree(1) doesn't
mention any configuration item, and neither does the zsh autocompletion.
Having a commit-tree.gpgsign config item (defaulting to the value of
commit.gpgsign, IMHO, but not necessarily) would definitly cover this
bug report.
> It's possible that there's a use case that
> would warrant it. But for this particular use case, passing the
> option explicitly from "gbp import-orig" seems preferable.
Right, it probably makes sense for gbp to do something clever here.
Anyway, as I said I'd call myself happy with whatever solution that
doesn't make me pass extra manual flags, tweaking user configuration
files of any kind is fine :)
Anyway, did something changed behaviour "recently"? Like gbp starting
to use commit-tree instead of commit?
--
regards,
Mattia Rizzolo
GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`.
more about me: https://mapreri.org : :' :
Launchpad user: https://launchpad.net/~mapreri `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia `-
signature.asc
Description: PGP signature
