Source: json-c
Version: 0.12.1-1
Severity: serious
Justification: fails to build from source
Dear Maintainer,
json-c fails to build from source due to a potential implicit
fall-through in function json_object_get_int64() from json_object.c:
libtool: compile: gcc -DHAVE_CONFIG_H -I. -Wdate-time -D_FORTIFY_SOURCE=2
-Wall -Werror -Wno-error=deprecated-declarations
-Wno-error=unused-but-set-variable -Wextra -Wwrite-strings
-Wno-unused-parameter -std=gnu99 -D_GNU_SOURCE -D_REENTRANT -g -O2
-fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat
-Werror=format-security -c json_object.c -fPIC -DPIC -o .libs/json_object.o
json_object.c: In function 'json_object_get_int64':
json_object.c:554:5: error: this statement may fall through
[-Werror=implicit-fallthrough=]
if (json_parse_int64(jso->o.c_string.str, &cint) == 0) return cint;
^
json_object.c:555:3: note: here
default:
^~~~~~~
cc1: all warnings being treated as errors
Makefile:578: recipe for target 'json_object.lo' failed
make[3]: *** [json_object.lo] Error 1
make[3]: Leaving directory '/<<PKGBUILDDIR>>'
A quick look at the latest upstream release gave me the impression that
his might have been fixed upstream in release 0.13:
https://github.com/json-c/json-c/blob/json-c-0.13-20171207/json_object.c#L697-L703
Cheers
jonas
-- System Information:
Debian Release: 9.3
APT prefers stable-updates
APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 4.9.0-5-amd64 (SMP w/4 CPU cores)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8) (ignored: LC_ALL
set to en_US.UTF-8), LANGUAGE=de_DE.UTF-8 (charmap=UTF-8) (ignored: LC_ALL set
to en_US.UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
